From 3b09a61fc4bb262ba03120b640f975e4f179413a Mon Sep 17 00:00:00 2001 From: Samuel Roldan Date: Mon, 11 Mar 2024 20:16:51 -0400 Subject: [PATCH 1/3] docs: Add 2024-03-07 meeting notes --- notes/2024/2024-03-07.md | 78 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 notes/2024/2024-03-07.md diff --git a/notes/2024/2024-03-07.md b/notes/2024/2024-03-07.md new file mode 100644 index 0000000..20aa937 --- /dev/null +++ b/notes/2024/2024-03-07.md @@ -0,0 +1,78 @@ +# 2024-03-07 ESLint TSC Meeting Notes + +## Transcript + +[`2024-03-07-transcript.md`](2024-03-07-transcript.md) + +## Attending + +- Nicholas C. Zakas (@nzakas) - TSC +- Milos Djermanovic (@mdjermanovic) - TSC +- (@fasttime) - TSC + +@nzakas moderated, and @sam3k took notes. + +## Topics + +### Proposal: Add More Columns to Triage Board + +**Agenda Item:** I'd like to suggest we add a couple new columns to the Triage board to help deal with PRs. Right now, all open PRs end up in the "Implementing" column, even though they may not all be in the same state. I propose adding "Additional Review Needed" for PRs where there is one approval but that person would like another review before merging, and "Merge Candidate" for PRs we believe are ready for merge but just want a double-check. We could then review these two columns before each release to check which ones might be ready. + +**Resolution:** we've agreed to add those two columns to the Triage board. + +**Action Items:** @nzakas will send and email to notify team and update the triage process docs + +### Proposal: Modify PR Approval Process + +**Agenda Item:** we have the repo set up so that PR approvals are not removed when new commits are pushed, which is confusing. Sometimes I've approved a PR and then there are several more commits that I haven't seen, but our settings make it seem like I've approved. GitHub has a setting that removes approvals when new commits are pushed. Shall we enable it? + +**Resolution:** we've agreed to dismiss stale pull requests reviews on all repos, and that we won't require re-review of previous approvers so long as our usual pull request merge requirements are met. + +**Action Items:** @mdjermanovic will implement this change + +### [feat!: move AST traversal into SourceCode](https://github.com/eslint/eslint/pull/18167) + +**TSC Summary:** As part of this work, we are moving the AST traversal from Linter into SourceCode. For normal AST traversal, this works exactly the same way; for code path analysis, there is actually a difference. With the traversal in Linter, the code paths are incomplete during the traversal and are only completed upon complete traversal of the AST. That means CodePathSegment fields like nextSegments and prevSegments would be empty when onCodePathSegment is called with Linter traversal, whereas they would be filled with SourceCode traversal. Rules relying on the Linter-based traversal of incomplete code path data might not work correctly when all data is present. + +In our codebase we have three rules that broke: no-useless-returns, no-this-before-super, and super-constructor. + +**TSC Question:** This would be another breaking change for v9.0.0. Are we okay with that? + +**Resolution:** we've agreed to include this PR in v9. + +**Action Items:** @nzakas will keep working on it to get to completion + +### [v9.0.0](https://github.com/orgs/eslint/projects/4/views/2) + +#### [Bug: Incorrect code path analysis for return in try blocks with catch clause](https://github.com/eslint/eslint/issues/17579) + +**Status:** @fasttime has just done some analysis so far. He could try to change the code path analysis as suggested [here](https://github.com/eslint/eslint/issues/17579#issuecomment-1969338176) if we are okay with that solution. This could take some weeks to complete. + +**Resolution:** we will follow up on the issue in a couple of weeks and move to v10 if we are not quite ready. + +#### [Change Request: Flat Config does not support FileEnumerator](https://github.com/eslint/eslint/issues/18087) + +**Status:** there doesn't seem to be a lot of urgency from Jordan to get this resolved, so I don't see any reason to hold up a potential release candidate for it. + +**Resolution:** removing from v9 board + +#### [feat: Add support for TS config files](https://github.com/eslint/eslint/pull/18134) + +**Resolution:** removing from v9 and requesting an RFC. + +#### [feat: support the new flat config](https://github.com/eslint/create-config/issues/51) + +**Status:** almost done + +**Action Items:** need one more reviewer + +#### [Switch Playground to flat config](https://github.com/eslint/eslint.org/issues/507) + +**Status:** almost done + +### Scheduled release for March 10th, 2024 + +**Action Items:** @mdjermanovic will release the following: + +- `eslint` +- `@eslint/js` From 455582327aed494c5191cd35ff1ab9408f03622d Mon Sep 17 00:00:00 2001 From: Samuel Roldan Date: Tue, 12 Mar 2024 06:31:31 -0400 Subject: [PATCH 2/3] Update 2024-03-07.md Co-authored-by: Milos Djermanovic --- notes/2024/2024-03-07.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notes/2024/2024-03-07.md b/notes/2024/2024-03-07.md index 20aa937..20b4263 100644 --- a/notes/2024/2024-03-07.md +++ b/notes/2024/2024-03-07.md @@ -8,7 +8,7 @@ - Nicholas C. Zakas (@nzakas) - TSC - Milos Djermanovic (@mdjermanovic) - TSC -- (@fasttime) - TSC +- Francesco Trotta (@fasttime) - TSC @nzakas moderated, and @sam3k took notes. From f4973fb41a245068de323106bac15e95d4ba200b Mon Sep 17 00:00:00 2001 From: Samuel Roldan Date: Tue, 12 Mar 2024 06:31:45 -0400 Subject: [PATCH 3/3] Update 2024-03-07.md Co-authored-by: Milos Djermanovic --- notes/2024/2024-03-07.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notes/2024/2024-03-07.md b/notes/2024/2024-03-07.md index 20b4263..66ec2c4 100644 --- a/notes/2024/2024-03-07.md +++ b/notes/2024/2024-03-07.md @@ -70,7 +70,7 @@ In our codebase we have three rules that broke: no-useless-returns, no-this-befo **Status:** almost done -### Scheduled release for March 10th, 2024 +### Scheduled release for March 8th, 2024 **Action Items:** @mdjermanovic will release the following: