Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for 3.16.1 #1832

Open
rradhara-eng opened this issue Feb 14, 2025 · 4 comments
Open

Request for 3.16.1 #1832

rradhara-eng opened this issue Feb 14, 2025 · 4 comments

Comments

@rradhara-eng
Copy link

I'm from AMD and I have used the patch from here ( #1708 ) to solve a performance drop observed on one of our 10G ethernet solutions.

The issue was observed with 3.16 version of iperf. I see that this fix is merged to 3.17. Given the performance impact, could you please consider providing a 3.16.1 release so that we can pull it into our builds?

@davidBar-On
Copy link
Contributor

Why can't you use the latest uperf3 release that includes this fix?
Also, if only this fix is needed, can you build iperf3 using PR #1708 code?.

@rradhara-eng
Copy link
Author

Hi @davidBar-On,

Thanks for your response.

I did cherry pick that PR and it works. But for the proper release (we are using Yocto LTS), the current recipe is for 3.16. We can however pick tags like 3.16.x. Since this is a valid fix to improve performance, can you please consider doing a tag? This should be useful both for us and other users. Please do let me know your thoughts.

@davidBar-On
Copy link
Contributor

can you please consider doing a tag? This should be useful both for us and other users.

Hi @rradhara-eng, I am not from the iperf3 team, so I cannot help with this. Hopefully someone from the iperf3 maintenance team can respond. The only thing I can suggest is to somehow upgrade to the latest version (3.18).

@bmah888
Copy link
Contributor

bmah888 commented Mar 24, 2025

@rradhara-eng if you can update to a tag, why can't you just update to the 3.18 tag? (I think you would need 3.18, not 3.17, to get the fix for #1708)

Doing a point-fix for this needs a branch, merge, tag, build, tests, etc., all of which need to be done by our small and very-time-constrained development team. In general we want users to be running the latest official releases anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants