Add secure-pad-v2 option with separate padding segment

Author: thetek42

espflash/src/cli/mod.rs

@@ -253,6 +253,9 @@ pub struct ImageArgs {
     /// MMU page size.
     #[arg(long, value_name = "MMU_PAGE_SIZE", value_parser = parse_u32)]
     pub mmu_page_size: Option<u32>,
+    /// Whether to apply padding for secure boot v2
+    #[arg(long)]
+    pub secure_pad_v2: bool,
 }
 
 #[derive(Debug, Args)]
@@ -1060,6 +1063,7 @@ pub fn make_flash_data(
         flash_settings,
         image_args.min_chip_rev,
         image_args.mmu_page_size,
+        image_args.secure_pad_v2,
     )
 }
 

espflash/src/flasher/mod.rs

@@ -477,6 +477,7 @@ pub struct FlashData {
     pub flash_settings: FlashSettings,
     pub min_chip_rev: u16,
     pub mmu_page_size: Option<u32>,
+    pub secure_pad_v2: bool,
 }
 
 impl FlashData {
@@ -488,6 +489,7 @@ impl FlashData {
         flash_settings: FlashSettings,
         min_chip_rev: u16,
         mmu_page_size: Option<u32>,
+        secure_pad_v2: bool,
     ) -> Result<Self, Error> {
         // If the '--bootloader' option is provided, load the binary file at the
         // specified path.
@@ -520,6 +522,7 @@ impl FlashData {
             flash_settings,
             min_chip_rev,
             mmu_page_size,
+            secure_pad_v2,
         })
     }
 }

espflash/src/image_format/esp_idf.rs

@@ -401,6 +401,18 @@ impl<'a> IdfBootloaderFormat<'a> {
             segment_count += 1;
         }
 
+        if flash_data.secure_pad_v2 {
+            let current_size = data.len();
+            let padding_size = (65536 - ((current_size + 56) % 65536)) % 65536;
+            let padding_bytes = vec![0; padding_size];
+            let segment = Segment {
+                addr: 0,
+                data: Cow::Owned(padding_bytes),
+            };
+            checksum = save_segment(&mut data, &segment, checksum)?;
+            segment_count += 1;
+        }
+
         let padding = 15 - (data.len() % 16);
         let padding = &[0u8; 16][0..padding];
         data.write_all(padding)?;