Allow USB Midi descriptor to be changed

[aaronaverill]

Related area

USBMIDI

Hardware specification

Generic

Is your feature request related to a problem?

The USB device descriptor always shows up as "TinyUSB MIDI", I can't change it

Describe the solution you'd like

Change the literal in this code to a define: USB_MIDI_DESCRIPTOR

https://github.com/espressif/arduino-esp32/blob/master/libraries/USB/src/USBMIDI.cpp#L21

uint8_t str_index = tinyusb_add_string_descriptor(USB_MIDI_DESCRIPTOR);

At the top of the module, add the following block:
#ifndef USB_MIDI_DESCRIPTOR
#define USB_MIDI_DESCRIPTOR "TinyUSB MIDI"
#endif

Now a build define will allow this to be changed so it shows up correctly under the MIDI devices.

Describe alternatives you've considered

This is being called by a library I use, so there is really no way to override the name without a whole bunch of copied code.

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

• I confirm I have checked existing list of Feature requests and Contribution Guide.

[SuGlider]

@aaronaverill - The proposed solution inthe PR #11720 would be like this:

// Create the MIDI device with specific descriptor
USBMIDI MIDI("ESP MIDI Device");

[aaronaverill]

@aaronaverill - The proposed solution inthe PR #11720 would be like this:

// Create the MIDI device with specific descriptor
USBMIDI MIDI("ESP MIDI Device");

I actually appreciate this abstraction more than a #define.

However...

I use a library (https://github.com/tttapa/Control-Surface) which instantiates the USBMidi classes somewhere in the bowels of it's code that I do not have access to. So this workaround is not going to work without additional support in THAT library. I suppose there are many architectures that work like this that would require changes to support this.

And while a parameter to the constructor is super useful for people using this directly, and a nice object oriented abstraction, the #define does feel like an appropriate solution that is common in the arduino world.

For now I've patched my local code to allow the #define so this isn't critical.

I like the option to change the name since it shows up in MIDI software.