Skip to content

Commit 41ffab0

Browse files
[CI] Fix generate_report call parameters
The recursive call to generate_report if the failure information was too big was not type-correct because it was never updated after we added support for parsing ninja logs. This did not cause test failures or runtime failures because we never looked at that variable or any afterwards in this case, and list_failures was set as a keyword arg. This might have caused issues somewhere though, and certainly does trip up a type checker. Found using pyright in vscode.
1 parent ff64261 commit 41ffab0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.ci/generate_test_report_lib.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,7 @@ def plural(num_tests):
298298
title,
299299
return_code,
300300
junit_objects,
301+
ninja_logs,
301302
size_limit,
302303
list_failures=False,
303304
)

0 commit comments

Comments
 (0)