Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase request timeout to 10 minutes (from 30 seconds) #20

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

kumekay
Copy link
Collaborator

@kumekay kumekay commented Sep 20, 2024

Description

Some bigger components cannot be reliably uploaded through the action, due to relatively low timeout. This PR sets the timeout to 10 minutes.

An example of failed job for the component about 80Mb in size:
https://github.com/espressif/idf-extra-components/actions/runs/10919154946/job/30306218942?pr=377

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@kumekay
Copy link
Collaborator Author

kumekay commented Sep 20, 2024

@XDanielPaul PTAL

@XDanielPaul
Copy link

XDanielPaul commented Sep 20, 2024

@kumekay
Looks good to me!
Just to make sure (as I have not been uploading huge components), this also includes time reserve for components with 200MiB right?

@kumekay
Copy link
Collaborator Author

kumekay commented Sep 20, 2024

@kumekay Looks good to me! Just to make sure (as I have not been uploading huge components), this also includes time reserve for components with 200MiB right?

GitHub Actions upload to the registry usually no slower than 10Mbit/s, for 200Mb to be sent in 10 minutes 3Mbit/s is enough. I believe this gives plenty of room.

@kumekay kumekay merged commit b78a19f into v1 Sep 27, 2024
@kumekay kumekay deleted the feat/increase_timeout branch September 27, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants