fix linting and typing issue

Author: LouisTsai-Csie

src/ethereum_test_types/phase_manager.py

@@ -25,7 +25,7 @@ class TestPhaseManager:
     Only supports "setup" and "execution" phases now.
     """
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args: Any, **kwargs: Any) -> None:  # noqa: ARG002
         """Initialize TestPhaseManager with empty transactions and blocks."""
         self.setup_transactions: List = []
         self.setup_blocks: List = []
@@ -53,7 +53,7 @@ def execution(self) -> Iterator["TestPhaseManager"]:
         finally:
             self._current_phase = old_phase
 
-    def add_transaction(self, tx) -> None:
+    def add_transaction(self, tx: Any) -> None:
         """Add a transaction to the current phase."""
         current_phase = self._current_phase
         tx.test_phase = current_phase
@@ -63,7 +63,7 @@ def add_transaction(self, tx) -> None:
         else:
             self.setup_transactions.append(tx)
 
-    def add_block(self, block) -> None:
+    def add_block(self, block: Any) -> None:
         """Add a block to the current phase."""
         current_phase = self._current_phase
         for tx in block.txs:
@@ -84,7 +84,7 @@ def __get_pydantic_core_schema__(
     ) -> PlainValidatorFunctionSchema:
         """Pydantic schema for TestPhaseManager."""
 
-        def validate_test_phase_manager(value):
+        def validate_test_phase_manager(value: Any) -> Any:
             """Return the TestPhaseManager instance as-is."""
             if isinstance(value, source_type):
                 return value

src/ethereum_test_types/tests/test_phase_manager.py

@@ -8,13 +8,13 @@
 from ..phase_manager import TestPhase, TestPhaseManager
 
 
-def test_test_phase_enum_values():
+def test_test_phase_enum_values() -> None:
     """Test that TestPhase enum has correct values."""
     assert TestPhase.SETUP.value == "setup"
     assert TestPhase.EXECUTION.value == "execution"
 
 
-def test_phase_manager_initialization():
+def test_phase_manager_initialization() -> None:
     """Test TestPhaseManager initialization."""
     manager = TestPhaseManager()
     assert len(manager.setup_transactions) == 0
@@ -24,7 +24,7 @@ def test_phase_manager_initialization():
     assert manager.get_current_phase() == TestPhase.EXECUTION
 
 
-def test_phase_manager_accepts_args_kwargs():
+def test_phase_manager_accepts_args_kwargs() -> None:
     """Test that __init__ accepts arbitrary args and kwargs."""
     # These should not cause errors
     manager1 = TestPhaseManager()
@@ -41,7 +41,7 @@ def test_phase_manager_accepts_args_kwargs():
         assert manager.get_current_phase() == TestPhase.EXECUTION
 
 
-def test_add_transaction_execution_phase():
+def test_add_transaction_execution_phase() -> None:
     """Test adding transaction in execution phase."""
     manager = TestPhaseManager()
     tx = Transaction(to=Address(0x123), value=100, gas_limit=21000)
@@ -54,7 +54,7 @@ def test_add_transaction_execution_phase():
     assert len(manager.setup_transactions) == 0
 
 
-def test_add_transaction_setup_phase():
+def test_add_transaction_setup_phase() -> None:
     """Test adding transaction in setup phase."""
     manager = TestPhaseManager()
     tx = Transaction(to=Address(0x456), value=50, gas_limit=21000)
@@ -68,7 +68,7 @@ def test_add_transaction_setup_phase():
     assert len(manager.execution_transactions) == 0
 
 
-def test_add_block_execution_phase():
+def test_add_block_execution_phase() -> None:
     """Test adding block in execution phase."""
     manager = TestPhaseManager()
     tx1 = Transaction(to=Address(0x111), value=100, gas_limit=21000)
@@ -84,7 +84,7 @@ def test_add_block_execution_phase():
     assert len(manager.setup_blocks) == 0
 
 
-def test_add_block_setup_phase():
+def test_add_block_setup_phase() -> None:
     """Test adding block in setup phase."""
     manager = TestPhaseManager()
     tx1 = Transaction(to=Address(0x333), value=100, gas_limit=21000)
@@ -112,7 +112,9 @@ def test_add_block_setup_phase():
         pytest.param(5, 0, 0, 5, id="many_items"),
     ],
 )
-def test_mixed_operations(num_setup_txs, num_setup_blocks, num_exec_txs, num_exec_blocks):
+def test_mixed_operations(
+    num_setup_txs: int, num_setup_blocks: int, num_exec_txs: int, num_exec_blocks: int
+) -> None:
     """Test mixed operations across phases."""
     manager = TestPhaseManager()
 
@@ -159,7 +161,7 @@ def test_mixed_operations(num_setup_txs, num_setup_blocks, num_exec_txs, num_exe
             assert tx.test_phase == TestPhase.EXECUTION.value
 
 
-def test_empty_block_handling():
+def test_empty_block_handling() -> None:
     """Test handling of empty blocks."""
     manager = TestPhaseManager()
     empty_block = Block(txs=[])
@@ -171,7 +173,7 @@ def test_empty_block_handling():
     assert len(manager.setup_blocks[0].txs) == 0
 
 
-def test_block_with_many_transactions():
+def test_block_with_many_transactions() -> None:
     """Test block with many transactions gets all transactions marked."""
     manager = TestPhaseManager()
 
@@ -193,7 +195,7 @@ def test_block_with_many_transactions():
         assert tx.test_phase == TestPhase.SETUP.value
 
 
-def test_phase_switching_preserves_existing_data():
+def test_phase_switching_preserves_existing_data() -> None:
     """Test that phase switching doesn't affect existing data."""
     manager = TestPhaseManager()
 
@@ -224,7 +226,7 @@ def test_phase_switching_preserves_existing_data():
     assert exec_values == [100, 200, 300]
 
 
-def test_multiple_managers_phase_isolation():
+def test_multiple_managers_phase_isolation() -> None:
     """Test that phase dependence for managers is isolated."""
     manager1 = TestPhaseManager()
     manager2 = TestPhaseManager()
@@ -268,7 +270,7 @@ def test_multiple_managers_phase_isolation():
         pytest.param(TestPhaseManager(), TestPhase.EXECUTION, id="new_instance"),
     ],
 )
-def test_manager_properties(manager_instance, expected_phase):
+def test_manager_properties(manager_instance: TestPhaseManager, expected_phase: TestPhase) -> None:
     """Test TestPhaseManager instance properties."""
     assert isinstance(manager_instance, TestPhaseManager)
     assert manager_instance.get_current_phase() == expected_phase

src/pytest_plugins/shared/transaction_fixtures.py

@@ -166,6 +166,6 @@ def typed_transaction(request: pytest.FixtureRequest, fork: Fork) -> Transaction
 
 
 @pytest.fixture(scope="function")
-def test_phase_manager():
+def test_phase_manager() -> TestPhaseManager:
     """Fixture providing access to a test phase manager."""
     return TestPhaseManager()