feat(forks): Enforce keyword-only arguments in fork methods (#1714)

* Enforce keyword-only arguments in calldata_gas_calculator methods and calls

* Apply keyword-only enforcement to all BaseFork methods and implementations

* fixes

---------

Co-authored-by: Abhishek Kafle <[email protected]>
Co-authored-by: Mario Vega <[email protected]>

Author: 3 people

docs/writing_tests/fork_methods.md

@@ -188,7 +188,7 @@ Example of adding a new method:
 ```python
 @classmethod
 @abstractmethod
-def supports_new_feature(cls, block_number: int = 0, timestamp: int = 0) -> bool:
+def supports_new_feature(cls, *, block_number: int = 0, timestamp: int = 0) -> bool:
     """Return whether the given fork supports the new feature."""
     pass
 ```
@@ -197,7 +197,7 @@ Implementation in a fork class:
 
 ```python
 @classmethod
-def supports_new_feature(cls, block_number: int = 0, timestamp: int = 0) -> bool:
+def supports_new_feature(cls, *, block_number: int = 0, timestamp: int = 0) -> bool:
     """Return whether the given fork supports the new feature."""
     return False  # Frontier doesn't support this feature
 ```
@@ -206,7 +206,7 @@ Implementation in a newer fork class:
 
 ```python
 @classmethod
-def supports_new_feature(cls, block_number: int = 0, timestamp: int = 0) -> bool:
+def supports_new_feature(cls, *, block_number: int = 0, timestamp: int = 0) -> bool:
     """Return whether the given fork supports the new feature."""
     return True  # This fork does support the feature
 ```

src/ethereum_test_fixtures/blockchain.py

@@ -103,7 +103,9 @@ def __new__(cls, value: str) -> "HeaderForkRequirement":
 
     def required(self, fork: Fork, block_number: int, timestamp: int) -> bool:
         """Check if the field is required for the given fork."""
-        return getattr(fork, f"header_{self}_required")(block_number, timestamp)
+        return getattr(fork, f"header_{self}_required")(
+            block_number=block_number, timestamp=timestamp
+        )
 
     @classmethod
     def get_from_annotation(cls, field_hints: Any) -> "HeaderForkRequirement | None":
@@ -238,9 +240,13 @@ def genesis(cls, fork: Fork, env: Environment, state_root: Hash) -> "FixtureHead
         environment_values["extra_data"] = env.extra_data
         extras = {
             "state_root": state_root,
-            "requests_hash": Requests() if fork.header_requests_required(0, 0) else None,
+            "requests_hash": Requests()
+            if fork.header_requests_required(block_number=0, timestamp=0)
+            else None,
             "block_access_list_hash": (
-                BlockAccessList().rlp_hash if fork.header_bal_hash_required(0, 0) else None
+                BlockAccessList().rlp_hash
+                if fork.header_bal_hash_required(block_number=0, timestamp=0)
+                else None
             ),
             "fork": fork,
         }
@@ -356,14 +362,18 @@ def from_fixture_header(
         **kwargs,
     ) -> "FixtureEngineNewPayload":
         """Create `FixtureEngineNewPayload` from a `FixtureHeader`."""
-        new_payload_version = fork.engine_new_payload_version(header.number, header.timestamp)
+        new_payload_version = fork.engine_new_payload_version(
+            block_number=header.number, timestamp=header.timestamp
+        )
         forkchoice_updated_version = fork.engine_forkchoice_updated_version(
-            header.number, header.timestamp
+            block_number=header.number, timestamp=header.timestamp
         )
 
         assert new_payload_version is not None, "Invalid header for engine_newPayload"
 
-        if fork.engine_execution_payload_block_access_list(header.number, header.timestamp):
+        if fork.engine_execution_payload_block_access_list(
+            block_number=header.number, timestamp=header.timestamp
+        ):
             if block_access_list is None:
                 raise ValueError(
                     f"`block_access_list` is required in engine `ExecutionPayload` for >={fork}."
@@ -377,19 +387,25 @@ def from_fixture_header(
         )
 
         params: List[Any] = [execution_payload]
-        if fork.engine_new_payload_blob_hashes(header.number, header.timestamp):
+        if fork.engine_new_payload_blob_hashes(
+            block_number=header.number, timestamp=header.timestamp
+        ):
             blob_hashes = Transaction.list_blob_versioned_hashes(transactions)
             if blob_hashes is None:
                 raise ValueError(f"Blob hashes are required for ${fork}.")
             params.append(blob_hashes)
 
-        if fork.engine_new_payload_beacon_root(header.number, header.timestamp):
+        if fork.engine_new_payload_beacon_root(
+            block_number=header.number, timestamp=header.timestamp
+        ):
             parent_beacon_block_root = header.parent_beacon_block_root
             if parent_beacon_block_root is None:
                 raise ValueError(f"Parent beacon block root is required for ${fork}.")
             params.append(parent_beacon_block_root)
 
-        if fork.engine_new_payload_requests(header.number, header.timestamp):
+        if fork.engine_new_payload_requests(
+            block_number=header.number, timestamp=header.timestamp
+        ):
             if requests is None:
                 raise ValueError(f"Requests are required for ${fork}.")
             params.append(requests)