test(eip7928): add EXTCODECOPY OOG memory expansion BAL test

Author: qu0b

tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_journal_revert.py

@@ -0,0 +1,118 @@
+"""
+Tests for EIP-7928 Block Access Lists - OOG Gas Check Ordering.
+
+Verifies that account access is NOT recorded in BAL when EXTCODECOPY fails
+due to OOG at memory expansion. Gas for all components (cold access + copy +
+memory expansion) must be checked BEFORE recording account access.
+"""
+
+import pytest
+from execution_testing import (
+    Account,
+    Alloc,
+    BalAccountExpectation,
+    Block,
+    BlockAccessListExpectation,
+    BlockchainTestFiller,
+    Bytecode,
+    Fork,
+    Op,
+    Transaction,
+)
+
+from .spec import ref_spec_7928
+
+REFERENCE_SPEC_GIT_PATH = ref_spec_7928.git_path
+REFERENCE_SPEC_VERSION = ref_spec_7928.version
+
+
+pytestmark = pytest.mark.valid_from("Amsterdam")
+
+
+@pytest.mark.parametrize(
+    "memory_offset,copy_size,gas_shortfall",
+    [
+        pytest.param(0x10000, 32, "large", id="large_offset"),
+        pytest.param(256, 32, "boundary", id="boundary"),
+    ],
+)
+def test_extcodecopy_oog_at_memory_expansion(
+    pre: Alloc,
+    blockchain_test: BlockchainTestFiller,
+    fork: Fork,
+    memory_offset: int,
+    copy_size: int,
+    gas_shortfall: str,
+) -> None:
+    """
+    Test EXTCODECOPY OOG at memory expansion - target should NOT appear in BAL.
+
+    Gas for all components (cold access + copy + memory expansion) must be
+    checked BEFORE recording account access.
+    """
+    alice = pre.fund_eoa()
+    gas_costs = fork.gas_costs()
+
+    target_contract = pre.deploy_contract(code=Bytecode(Op.STOP))
+
+    # Build EXTCODECOPY contract with appropriate PUSH sizes
+    if memory_offset <= 0xFF:
+        dest_push = Op.PUSH1(memory_offset)
+    elif memory_offset <= 0xFFFF:
+        dest_push = Op.PUSH2(memory_offset)
+    else:
+        dest_push = Op.PUSH3(memory_offset)
+
+    extcodecopy_contract_code = Bytecode(
+        Op.PUSH1(copy_size)
+        + Op.PUSH1(0)
+        + dest_push
+        + Op.PUSH20(target_contract)
+        + Op.EXTCODECOPY
+        + Op.STOP
+    )
+
+    extcodecopy_contract = pre.deploy_contract(code=extcodecopy_contract_code)
+
+    intrinsic_gas_calculator = fork.transaction_intrinsic_cost_calculator()
+    intrinsic_gas_cost = intrinsic_gas_calculator()
+
+    push_cost = gas_costs.G_VERY_LOW * 4
+    cold_access_cost = gas_costs.G_COLD_ACCOUNT_ACCESS
+    copy_cost = gas_costs.G_COPY * ((copy_size + 31) // 32)
+
+    if gas_shortfall == "large":
+        # Provide gas for push + cold access + copy, but NOT memory expansion
+        tx_gas_limit = intrinsic_gas_cost + push_cost + cold_access_cost + copy_cost
+    else:
+        # Calculate memory cost and provide exactly 1 less than needed
+        words = (memory_offset + copy_size + 31) // 32
+        memory_cost = (words * gas_costs.G_MEMORY) + (words * words // 512)
+        total_gas_needed = push_cost + cold_access_cost + copy_cost + memory_cost
+        tx_gas_limit = intrinsic_gas_cost + total_gas_needed - 1
+
+    tx = Transaction(
+        sender=alice,
+        to=extcodecopy_contract,
+        gas_limit=tx_gas_limit,
+    )
+
+    block = Block(
+        txs=[tx],
+        expected_block_access_list=BlockAccessListExpectation(
+            account_expectations={
+                extcodecopy_contract: BalAccountExpectation.empty(),
+                target_contract: None,
+            }
+        ),
+    )
+
+    blockchain_test(
+        pre=pre,
+        blocks=[block],
+        post={
+            alice: Account(nonce=1),
+            extcodecopy_contract: Account(),
+            target_contract: Account(),
+        },
+    )

tests/amsterdam/eip7928_block_level_access_lists/test_cases.md

@@ -94,3 +94,4 @@
 | `test_call_to_pre_authorized_oog` | Ensure BAL handles OOG during EIP-7702 delegation access (pre-Amsterdam test with BAL) | Call to delegated account that OOGs before accessing delegation contract | BAL **MUST** include auth_signer (code read for delegation check) but **MUST NOT** include delegation contract (OOG before access) | ✅ Completed |
 | `test_selfdestruct_created_in_same_tx_with_revert` | Ensure BAL tracks selfdestruct with revert correctly (pre-Amsterdam test with BAL) | Contract created and selfdestructed in same tx with nested revert | BAL **MUST** track storage reads and balance changes for selfdestruct even with reverts | ✅ Completed |
 | `test_value_transfer_gas_calculation` | Ensure BAL correctly tracks OOG scenarios for CALL/CALLCODE/DELEGATECALL/STATICCALL (pre-Amsterdam test with BAL) | Nested calls with precise gas limits to test OOG behavior. For CALL with OOG: target account read for `is_account_alive` check. For CALLCODE/DELEGATECALL/STATICCALL with OOG: target account **NOT** read (OOG before state access) | For CALL: target in BAL even with OOG. For CALLCODE/DELEGATECALL/STATICCALL: target **NOT** in BAL when OOG (state access deferred until after gas check) | ✅ Completed |
+| `test_extcodecopy_oog_at_memory_expansion` | Ensure BAL excludes target when EXTCODECOPY OOGs at memory expansion | Parameterized: (1) large_offset: 64KB memory offset, gas covers cold access + copy but NOT memory expansion. (2) boundary: 256 byte offset, gas is exactly 1 less than needed. | BAL **MUST NOT** include target contract. Gas must be checked for ALL components (cold access + copy + memory expansion) BEFORE recording account access. | ✅ Completed |