Skip to content

Constant evaluator support for member constants #16056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Constant evaluator support for member constants #16056

wants to merge 2 commits into from

Conversation

matheusaaguiar
Copy link
Collaborator

Fix #16055.

@matheusaaguiar matheusaaguiar self-assigned this May 18, 2025
@matheusaaguiar matheusaaguiar force-pushed the constantEvaluatorSupportForMemberAccess branch 2 times, most recently from 93d7f5a to 78e1d3e Compare May 19, 2025 04:41
@matheusaaguiar matheusaaguiar marked this pull request as ready for review May 19, 2025 04:41
@matheusaaguiar matheusaaguiar force-pushed the constantEvaluatorSupportForMemberAccess branch from 1e7955b to 985b03f Compare May 20, 2025 15:13
clonker
clonker reviewed May 22, 2025
View reviewed changes
Copy link
Member

@clonker clonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if there aren't any unwanted side-effects hiding in this. Looks good to me generally, though!

@matheusaaguiar matheusaaguiar force-pushed the constantEvaluatorSupportForMemberAccess branch from ad3f23a to 7fa4363 Compare May 22, 2025 22:26
clonker
clonker reviewed May 23, 2025
View reviewed changes
clonker
clonker previously approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@clonker clonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the typo

@matheusaaguiar matheusaaguiar force-pushed the constantEvaluatorSupportForMemberAccess branch 2 times, most recently from e596763 to d5beb9e Compare May 23, 2025 14:35
@matheusaaguiar matheusaaguiar force-pushed the constantEvaluatorSupportForMemberAccess branch from d5beb9e to 9d5f93f Compare June 4, 2025 13:57
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clonker clonker clonker left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@matheusaaguiar matheusaaguiar

Labels
stale The issue/PR was marked as stale because it has been open for too long.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile-time evaluation of constants of member constants
2 participants
@matheusaaguiar @clonker