Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Ticket - For Dev team discussion #27

Open
3 of 22 tasks
RustyBraze opened this issue Sep 6, 2024 · 4 comments
Open
3 of 22 tasks

Live Ticket - For Dev team discussion #27

RustyBraze opened this issue Sep 6, 2024 · 4 comments
Assignees
Labels
Discussion Let's have a talk...

Comments

@RustyBraze
Copy link
Collaborator

RustyBraze commented Sep 6, 2024

Overview

This is a live ticket that has points of discussion for the Dev Team

Does not mean that everything here will be implemented or done.

Topics

  • Normalization of the application name (code and ui) - Angel vs. Critter
  • Migration function - fail to "migrate" depending the code page or type of system (windows/linux)
  • Force conversion of CRLF / LF > specially for scripts
  • Language files .po - Incomplete termination => error on execution/conversion > improve the testing when commit is done to catch this - example default.po missed on line 431 the "
  • Documentation - deployment for production (direct to web server fails)
  • Documentation - Internal permissions and access levels
  • Use of reverse proxy - for performance and scale - not depend only from the nginx inside the docker
  • Shift Creation - force the user to save or cancel after the preview - avoid data loss
  • Badge number - automatic or manual assigned
  • Telegram validation - for future integration
  • Explicit set flags for values and not only use NULL or "not empty"
  • create and define list of common terms and names - standardize development
  • create a GitHub team to simplify the code review request - avoid manual guess of who will review
  • Create a data archival policy and roll over policy - after the event, a way to keep the needed data and remove unwanted data (instead of doing manual work)
  • data export/import -> server side to simplify the work of dumping the content for re-upload > consider backup or disaster recovery #63
  • self sign up icon/indication icon improvement - replace with a checkmark maybe? (Save space on small screens and more clear visible) Or even group in sections to make it a bit easier to see
  • add a section only for admins to perform adjustments without the need to change the files directly and for quick fixes, example, email server or goodies
  • notification system for upcoming shifts -> can be merged with telegram notification
  • concept of reputation levels - to be more friendly
  • documentation - improve the files and host inside the folder 'docs'
  • GPG public keys - add a list of public keys to validate the commits this is not needed inside github
  • define a plan for the upstream repository - this means, make it generic that can be used by others or specific to us
@RustyBraze RustyBraze added the Discussion Let's have a talk... label Sep 6, 2024
@RustyBraze RustyBraze self-assigned this Sep 8, 2024
@Gemoron Gemoron pinned this issue Oct 25, 2024
@MyIgel
Copy link

MyIgel commented Dec 16, 2024

To normalize the translations you can also use the patch from https://engelsystem.de/doc/admin/translation/index.html which replaces them on the fly and allows better upstream compatibility ;)
(& if you want I'm happy to discuss any collaboration of upstream patches / changes to make your life easier in the future)

@RustyBraze
Copy link
Collaborator Author

@MyIgel We are using the translation module however, there are several instances the reference are just pure text and not keys for the references. The goal is to create key-based text and normalize the complete code.

For example, currently we have __('This user does not exist.') and in the future, should be __('user.unknown') (or something similar).

You may have noticed that our fork has a considerable number of changes and bugfixes implemented so far and we are also planning several more to come in the future.

I am even re-writting from scracth the API to allow integration with a Telegram Bot or any other interface/notification tool.

If you are still interested, we can have a talk.

@MyIgel
Copy link

MyIgel commented Dec 16, 2024

Thats also planned for the base engelsystem (although only for the newly written / rewritten code in src)

We can definitely have a talk at how to cooperate here / make it easier to integrate and eventually fix the bugs in the engelsystem too ;)

@RustyBraze
Copy link
Collaborator Author

Awesome! Feel free to ping me on Telegram. Same name as my Github user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Let's have a talk...
Projects
None yet
Development

No branches or pull requests

2 participants