Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size by rounding floats #8

Open
ai opened this issue Nov 28, 2023 · 2 comments
Open

Reduce size by rounding floats #8

ai opened this issue Nov 28, 2023 · 2 comments

Comments

@ai
Copy link
Member

ai commented Nov 28, 2023

Now we are using 6 digits for L after the comma: 0.917969.

Isn’t it too much? I think we can round it to 2-3 digits, and we will not be able to see the difference.

@nickserv
Copy link

nickserv commented Mar 7, 2024

I wonder if there's a way to determine how much this would affect the perceived color space programatically?

@vnphanquang
Copy link
Contributor

I too don't think one would see the difference between 0.917969 and 0.9180 but I don't see why we need to round it up either, especially when the palette is often loaded from either a node package or cdn.

For what it's worth, however, some references:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants