Skip to content

Commit 3934bbf

Browse files
committed
Re-enable Yahoo tests behind credential gating
Root cause: the Yahoo suite had been hard-skipped even when a user supplied credentials, which prevented intentional compatibility runs. Remove the unconditional Skip attributes so the existing settings gate controls whether the Yahoo tests execute.
1 parent 64450ba commit 3934bbf

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

test/Geocoding.Tests/YahooGeocoderTest.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,60 +19,60 @@ protected override IGeocoder CreateGeocoder()
1919
return new YahooGeocoder(_settings.YahooConsumerKey, _settings.YahooConsumerSecret);
2020
}
2121

22-
[Theory(Skip = "oauth not working for yahoo - see issue #27")]
22+
[Theory]
2323
[MemberData(nameof(AddressData), MemberType = typeof(GeocoderTest))]
2424
public override Task Geocode_ValidAddress_ReturnsExpectedResult(string address)
2525
{
2626
return base.Geocode_ValidAddress_ReturnsExpectedResult(address);
2727
}
2828

29-
[Fact(Skip = "oauth not working for yahoo - see issue #27")]
29+
[Fact]
3030
public override Task Geocode_NormalizedAddress_ReturnsExpectedResult()
3131
{
3232
return base.Geocode_NormalizedAddress_ReturnsExpectedResult();
3333
}
3434

35-
[Theory(Skip = "oauth not working for yahoo - see issue #27")]
35+
[Theory]
3636
[MemberData(nameof(CultureData), MemberType = typeof(GeocoderTest))]
3737
public override Task Geocode_DifferentCulture_ReturnsExpectedResult(string cultureName)
3838
{
3939
return base.Geocode_DifferentCulture_ReturnsExpectedResult(cultureName);
4040
}
4141

42-
[Theory(Skip = "oauth not working for yahoo - see issue #27")]
42+
[Theory]
4343
[MemberData(nameof(CultureData), MemberType = typeof(GeocoderTest))]
4444
public override Task ReverseGeocode_DifferentCulture_ReturnsExpectedResult(string cultureName)
4545
{
4646
return base.ReverseGeocode_DifferentCulture_ReturnsExpectedResult(cultureName);
4747
}
4848

49-
[Fact(Skip = "oauth not working for yahoo - see issue #27")]
49+
[Fact]
5050
public override Task Geocode_InvalidAddress_ReturnsEmpty()
5151
{
5252
return base.Geocode_InvalidAddress_ReturnsEmpty();
5353
}
5454

55-
[Theory(Skip = "oauth not working for yahoo - see issue #27")]
55+
[Theory]
5656
[MemberData(nameof(SpecialCharacterAddressData), MemberType = typeof(GeocoderTest))]
5757
public override Task Geocode_SpecialCharacters_ReturnsResults(string address)
5858
{
5959
return base.Geocode_SpecialCharacters_ReturnsResults(address);
6060
}
6161

62-
[Theory(Skip = "oauth not working for yahoo - see issue #27")]
62+
[Theory]
6363
[MemberData(nameof(StreetIntersectionAddressData), MemberType = typeof(GeocoderTest))]
6464
public override Task Geocode_StreetIntersection_ReturnsResults(string address)
6565
{
6666
return base.Geocode_StreetIntersection_ReturnsResults(address);
6767
}
6868

69-
[Fact(Skip = "oauth not working for yahoo - see issue #27")]
69+
[Fact]
7070
public override Task ReverseGeocode_WhiteHouseCoordinates_ReturnsExpectedArea()
7171
{
7272
return base.ReverseGeocode_WhiteHouseCoordinates_ReturnsExpectedArea();
7373
}
7474

75-
[Theory(Skip = "oauth not working for yahoo - see issue #27")]
75+
[Theory]
7676
[MemberData(nameof(InvalidZipCodeAddressData), MemberType = typeof(GeocoderTest))]
7777
public override Task Geocode_InvalidZipCode_ReturnsResults(string address)
7878
{

0 commit comments

Comments
 (0)