Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mat4 functions that take a matrix in to transform should not perform a backwards implicit mul #77

Open
shakesoda opened this issue Apr 29, 2022 · 1 comment
Assignees

Comments

@shakesoda
Copy link
Member

the usage is bad, and it causes math to be more confusing now that mul ordering was fixed a couple years ago. this would be a breaking change and probably prevent an enormous amount of confusing bugs from this legacy bit of the api

it's not really a bug so much as a legacy misfeature that should just go away. a long time ago it made using it easier.

signed, me who just explained the math to someone backwards for the last hour before realizing the logical inconsistency.

@shakesoda shakesoda self-assigned this Apr 29, 2022
@shakesoda
Copy link
Member Author

shakesoda commented Apr 29, 2022

clarification: functions such as mat4.scale take an a argument which is a base matrix to multiply with, which gets post-multiplied with the new matrix. this was helpful for making things act liked they seemed like they should a long time ago (before #33) was fixed, and is now just plain confusing, and wasteful when the sensible thing to do is to pass identity all the time.

the replacement will be to call mul yourself and not have to deal with this oddball behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant