Abort sending messages in case of error other than 404 (FCM)

[maszuDEV]

Hello,

I have a question for you that can help me solve the problem in my application. My doubts are about this piece of code:

noticed/lib/noticed/delivery_methods/fcm.rb

Lines 19 to 29 in 407de14

	def deliver
	device_tokens.each do |device_token|
	post("#{BASE_URI}#{project_id}/messages:send", headers: {authorization: "Bearer #{access_token}"}, json: {message: format(device_token)})
	rescue ResponseUnsuccessful => exception
	if exception.response.code == 404
	cleanup_invalid_token(device_token)
	else
	raise
	end
	end
	end

Do I understand correctly that when sending subsequent notifications, when any iteration returns a code other than success or 404, it will stop sending further messages?

Shouldn't we treat it as a bug in this case?

What do you think?

Best regards and thank you for your work!