Ability to require a record

[JamesChevalier]

We can require_params :param_name but require_params :record isn't functional - even if you set that record value it still produces the validation error

Param `record` is required for CommentNotifier. (Noticed::ValidationError)

I think this is because the params are being adjusted here, removing that record entry from the overall params hash:

noticed/app/models/concerns/noticed/deliverable.rb

Lines 48 to 51 in f8e0f8c

	def with(params)
	record = params.delete(:record)
	new(params: params, record: record)
	end

So by the time the required params check runs, the record has been taken out & the validation will fail.

[excid3]

That's correct. I think we may add an exception for :record so that it checks the database attributes instead of params instead.

[JamesChevalier]

Sounds good.
We should also update the readme to remove :record from the required_params entry in this section if the syntax is going to be different.

[excid3]

I think we'll leave it with required_params :record.

[excid3]

Actually... now that this is just an ActiveRecord model, maybe this should just become:

validates :record, presence: true

Then there's nothing fancy at all going on.

[excid3]

That works perfectly. Updated the readme!

[fig]

I think the docs could more explicitly point out that require_params :record is not the correct thing to do and will error.
I just got caught out by this and was pulling my hair out until I found this discussion.
I'm happy to submit a PR if you would like.