Evaluate mailer option

[ch000]

I'm trying to extract the delivery method configuration for email notifiers, but having trouble with the mailer option.

Example code:

module EmailNotifier
  extend ActiveSupport::Concern

  included do
    deliver_by :email do |c|
      c.mailer = :mailer
      c.method = :mailer_method
      c.params = :email_params
    end
  end
end

class UserWelcomeNotifier < BaseNotifier
  include EmailNotifier

  def mailer(*)
    "UserMailer"
  end

  def mailer_method(*)
    :welcome_mail
  end
end

This doesn't work, since the mailer option won't be evaluated:

noticed/lib/noticed/delivery_methods/email.rb

Line 7 in 0a223ce

mailer = fetch_constant(:mailer)

Is this intended, or would it be possible to evaluate the mailer option as well?

i.e. something like this:

mailer = evaluate_option(:mailer).then { |m| m.is_a?(String) ? m.constantize : m }

Thanks :)

[ch000]

I'm closing this discussion again. While the suggested change would work, i realised forcing the email config to a concern doesn't really make sense. The only shared config option in my case is config.if = :send_email_notification? (not even shown in my example).
I'm back defining the config block in each Notifier and the concern only holds the shared send_email_notification? method.

Thanks for all your work :)