Skip to content

tests(binary): error when git email auto-detection is disabled #824

Description

@ee7

Description

With 6691484, a configlet developer may see this error when running the integration tests locally:

[Suite] generate
Author identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: no email was given and auto-detection is disabled

Error when running `git -C /home/foo/exercism-configlet/tests/.test_elixir_track_repo commit -a -m config: convert `average_run_time` to int`
/home/foo/exercism-configlet/tests/test_binary.nim(1446) test_binary
/home/foo/exercism-configlet/tests/test_binary.nim(1440) main
/home/foo/exercism-configlet/tests/test_binary.nim(946) testsForGenerate
/home/foo/exercism-configlet/src/exec.nim(137) setupExercismRepo
/home/foo/exercism-configlet/src/exec.nim(123) fixAverageRunTimeInConfigJson
/home/foo/exercism-configlet/src/exec.nim(76) gitCheck
/home/foo/exercism-configlet/src/exec.nim(68) execAndCheck
Error: unhandled exception:  [OSError]

Possible solution

Move this logic from the workflow to the test file, and make it run conditionally:

- name: Configure the git user # Required to create a commit in our binary tests
run: |
git config --global user.email "66069679+exercism-bot@users.noreply.github.com"
git config --global user.name "Exercism Bot"

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind: testsAdding or refactoring tests

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions