workflows: resolve failures in staging build (fluent#4449)

* workflows: resolve failures in staging build

Signed-off-by: Patrick Stephens <[email protected]>

* workflows: fix link in README.md

Signed-off-by: Patrick Stephens <[email protected]>

Author: patrick-stephens

.github/workflows/README.md

@@ -3,7 +3,7 @@
 | Workflow file                                         | Description               | Run event                                         |
 | :---------------------------------------------------- | ------------------------  | ------------------------------------------------- |
 | [staging-build](./staging-build.yaml)            | Builds the distro packages and docker images from a tagged release into staging (S3 and GHCR) | on new release/tag |
-| [staging-test](./staging-build.yaml)            | Test the staging distro packages and docker images| manually or when `staging-build` completes successfully |
+| [staging-test](./staging-test.yaml)            | Test the staging distro packages and docker images| manually or when `staging-build` completes successfully |
 | [staging-release](./staging-release.yaml)        | Publishes the docker images/manifest on hub.docker.io/fluent/ and the distro packages | manual approval |
 | [pr-closed-docker](./pr-closed-docker.yaml)      | Removes docker images for PR on hub.docker.io/fluentbitdev/| on pr closed|
 | [pr-compile-check](./pr-compile-check.yaml)      | Runs some compilation sanity checks on a PR |

.github/workflows/call-build-packages.yaml

@@ -137,7 +137,9 @@ jobs:
       release: ${{ needs.deploy-get-version.outputs.releaseTag }}
     steps:
       - name: Install dependencies
-        run: sudo apt-get install createrepo debsigs apt-utils
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y createrepo debsigs apt-utils
 
       - name: Checkout code
         uses: actions/checkout@v2

packaging/update-repos.sh

@@ -22,7 +22,7 @@ for RPM_REPO in "${RPM_REPO_PATHS[@]}"; do
     createrepo -dvp "$REPO_DIR"
 
     # Set up repo info
-    if [[ -n "${AWS_S3_BUCKET}" ]]; then
+    if [[ -n "${AWS_S3_BUCKET:-}" ]]; then
         REPO_TYPE=${RPM_REPO%%/*}
         echo "Setting up $BASE_PATH/$REPO_TYPE.repo"
         cat << EOF > "$BASE_PATH/$REPO_TYPE.repo"
@@ -61,9 +61,9 @@ for DEB_REPO in "${DEB_REPO_PATHS[@]}"; do
     mkdir -p "$REPO_DIR/pool/main/t/td-agent-bit"
     mkdir -p "$REPO_DIR/pool/main/t/td-agent-bit-headers"
     mkdir -p "$REPO_DIR/pool/main/t/td-agent-bit-headers-extra"
-    mv $REPO_DIR/td-agent-bit*-headers-extra.deb "$REPO_DIR/pool/main/t/td-agent-bit-headers-extra/"
-    mv $REPO_DIR/td-agent-bit*-headers.deb "$REPO_DIR/pool/main/t/td-agent-bit-heaers/"
-    mv $REPO_DIR/td-agent-bit*.deb "$REPO_DIR/pool/main/t/td-agent-bit/"
+    mv "$REPO_DIR"/td-agent-bit*-headers-extra.deb "$REPO_DIR/pool/main/t/td-agent-bit-headers-extra/"
+    mv "$REPO_DIR"/td-agent-bit*-headers.deb "$REPO_DIR/pool/main/t/td-agent-bit-headers/"
+    mv "$REPO_DIR"/td-agent-bit*.deb "$REPO_DIR/pool/main/t/td-agent-bit/"
 
     # All paths must be relative and using `dists/CODENAME` for the package info
     pushd "$REPO_DIR"