Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tom's code review #26

Open
FomasTreeman opened this issue Oct 19, 2023 · 0 comments
Open

Tom's code review #26

FomasTreeman opened this issue Oct 19, 2023 · 0 comments

Comments

@FomasTreeman
Copy link

Best Practice Police! :) BPP

3 states of a cell could be represented as true / false / null and maybe named isHit. may be less human readable, but less chances for typos and easier to pick up logic errors. So its kinnda a preference thing, i just find its more specific and gives more control when using boolean + null. All this being said i don't entirely understand what the B is for, but hit and miss could be true or false, hopefully it applies for you.

Terminal warning to move styles dir outside of public. After googling i found this. 'Webpack doesn't read anything in the public folder it only reads from src folder so it is advised to placed the css/stylesheets in your src folder'.

Awesome project and super clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant