From 29af39e1fa110e9e499134d70b495626030d36ca Mon Sep 17 00:00:00 2001 From: Zilin Zhang Date: Mon, 20 Mar 2023 23:11:56 -0700 Subject: [PATCH] Fix referrer bug Summary: Fix issue https://github.com/facebook/facebook-android-sdk/issues/1039 , we'll need to end the connection to avoid leaks and performance problems. https://developer.android.com/google/play/installreferrer/library#closing-connection Reviewed By: wx0165927473 Differential Revision: D44238528 fbshipit-source-id: 868b108305c2aa964c91c2456309e45fd06e0070 --- .../main/java/com/facebook/internal/InstallReferrerUtil.kt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/facebook-core/src/main/java/com/facebook/internal/InstallReferrerUtil.kt b/facebook-core/src/main/java/com/facebook/internal/InstallReferrerUtil.kt index 337e5a1b45..73028f2991 100644 --- a/facebook-core/src/main/java/com/facebook/internal/InstallReferrerUtil.kt +++ b/facebook-core/src/main/java/com/facebook/internal/InstallReferrerUtil.kt @@ -54,6 +54,11 @@ object InstallReferrerUtil { updateReferrer() // No point retrying if feature not supported InstallReferrerResponse.SERVICE_UNAVAILABLE -> {} } + try { + referrerClient.endConnection() + } catch (e: Exception) { + // Silent endConnection errors for unit test and else + } } override fun onInstallReferrerServiceDisconnected() = Unit