enable to transform avif -> on client

Reviewed By: defHLT

Differential Revision: D70459157

fbshipit-source-id: 60df87b59e22fa80bdc91e32be73034b7fd31ac0

Author: Liel Cohen

imagepipeline-base/src/main/java/com/facebook/imagepipeline/transcoder/ImageTranscodeResult.kt

@@ -7,11 +7,13 @@
 
 package com.facebook.imagepipeline.transcoder
 
+import com.facebook.imageformat.ImageFormat
 import java.util.Locale
 
 /** Result returned by an [ImageTranscoder] when transcoding an image. */
 class ImageTranscodeResult(
-    @field:TranscodeStatus @get:TranscodeStatus @param:TranscodeStatus val transcodeStatus: Int
+    @field:TranscodeStatus @get:TranscodeStatus @param:TranscodeStatus val transcodeStatus: Int,
+    val outputFormat: ImageFormat
 ) {
   override fun toString(): String = String.format(null as Locale?, "Status: %d", transcodeStatus)
 }

imagepipeline-base/src/main/java/com/facebook/imagepipeline/transcoder/ImageTranscoder.kt

@@ -66,6 +66,14 @@ interface ImageTranscoder {
    */
   fun canTranscode(imageFormat: ImageFormat): Boolean
 
+  /**
+   * Determines whether the given image format should be transformed into a different format.
+   *
+   * @param imageFormat The [ImageFormat] of the input image.
+   * @return true if the image format should be transformed to a different format, else false.
+   */
+  fun canTransformAVIF(imageFormat: ImageFormat): Boolean
+
   /**
    * Gets the identifier of the image transcoder. This is mostly used for logging purposes.
    *

imagepipeline/src/main/java/com/facebook/imagepipeline/producers/ResizeAndRotateProducer.java

@@ -250,7 +250,7 @@ private void doTransform(
             CloseableReference.of(outputStream.toByteBuffer());
         try {
           ret = new EncodedImage(ref);
-          ret.setImageFormat(JPEG);
+          ret.setImageFormat(result.getOutputFormat());
           try {
             ret.parseMetaData();
             mProducerContext
@@ -322,7 +322,8 @@ private static TriState shouldTransform(
     return TriState.valueOf(
         shouldRotate(request.getRotationOptions(), encodedImage)
             || imageTranscoder.canResize(
-                encodedImage, request.getRotationOptions(), request.getResizeOptions()));
+                encodedImage, request.getRotationOptions(), request.getResizeOptions())
+            || imageTranscoder.canTransformAVIF(encodedImage.getImageFormat()));
   }
 
   private static boolean shouldRotate(RotationOptions rotationOptions, EncodedImage encodedImage) {

imagepipeline/src/main/java/com/facebook/imagepipeline/transcoder/SimpleImageTranscoder.kt

@@ -55,11 +55,11 @@ class SimpleImageTranscoder(private val resizingEnabled: Boolean, private val ma
           BitmapFactory.decodeStream(encodedImage.inputStream, null, options)
         } catch (oom: OutOfMemoryError) {
           FLog.e(TAG, "Out-Of-Memory during transcode", oom)
-          return ImageTranscodeResult(TranscodeStatus.TRANSCODING_ERROR)
+          return ImageTranscodeResult(TranscodeStatus.TRANSCODING_ERROR, encodedImage.imageFormat)
         }
     if (resizedBitmap == null) {
       FLog.e(TAG, "Couldn't decode the EncodedImage InputStream ! ")
-      return ImageTranscodeResult(TranscodeStatus.TRANSCODING_ERROR)
+      return ImageTranscodeResult(TranscodeStatus.TRANSCODING_ERROR, encodedImage.imageFormat)
     }
     val transformationMatrix =
         JpegTranscoderUtils.getTransformationMatrix(encodedImage, rotationOptions)
@@ -76,13 +76,15 @@ class SimpleImageTranscoder(private val resizingEnabled: Boolean, private val ma
                 transformationMatrix,
                 false)
       }
-      srcBitmap.compress(getOutputFormat(outputFormat), quality, outputStream)
+      val outputFormat = getOutputFormat(outputFormat)
+      srcBitmap.compress(outputFormat, quality, outputStream)
       ImageTranscodeResult(
           if (sampleSize > DownsampleUtil.DEFAULT_SAMPLE_SIZE) TranscodeStatus.TRANSCODING_SUCCESS
-          else TranscodeStatus.TRANSCODING_NO_RESIZING)
+          else TranscodeStatus.TRANSCODING_NO_RESIZING,
+          convertCompressFormatToImageFormat(outputFormat))
     } catch (oom: OutOfMemoryError) {
       FLog.e(TAG, "Out-Of-Memory during transcode", oom)
-      ImageTranscodeResult(TranscodeStatus.TRANSCODING_ERROR)
+      ImageTranscodeResult(TranscodeStatus.TRANSCODING_ERROR, encodedImage.imageFormat)
     } finally {
       srcBitmap.recycle()
       resizedBitmap.recycle()
@@ -107,6 +109,8 @@ class SimpleImageTranscoder(private val resizingEnabled: Boolean, private val ma
   override fun canTranscode(imageFormat: ImageFormat): Boolean =
       imageFormat === DefaultImageFormats.HEIF || imageFormat === DefaultImageFormats.JPEG
 
+  override fun canTransformAVIF(imageFormat: ImageFormat): Boolean = false
+
   override val identifier: String = "SimpleImageTranscoder"
 
   private fun getSampleSize(
@@ -152,4 +156,14 @@ class SimpleImageTranscoder(private val resizingEnabled: Boolean, private val ma
       }
     }
   }
+
+  /** Maps an Android [CompressFormat] back to the corresponding [ImageFormat]. */
+  private fun convertCompressFormatToImageFormat(compressFormat: CompressFormat): ImageFormat {
+    return when (compressFormat) {
+      CompressFormat.JPEG -> DefaultImageFormats.JPEG
+      CompressFormat.PNG -> DefaultImageFormats.PNG
+      CompressFormat.WEBP -> DefaultImageFormats.WEBP_SIMPLE
+      else -> DefaultImageFormats.JPEG
+    }
+  }
 }

native-imagetranscoder/src/main/java/com/facebook/imagepipeline/nativecode/NativeJpegTranscoder.java

@@ -78,6 +78,11 @@ public boolean canTranscode(ImageFormat imageFormat) {
     return imageFormat == DefaultImageFormats.JPEG;
   }
 
+  @Override
+  public boolean canTransformAVIF(ImageFormat imageFormat) {
+    return false;
+  }
+
   @Override
   public String getIdentifier() {
     return TAG;
@@ -146,7 +151,8 @@ public ImageTranscodeResult transcode(
     return new ImageTranscodeResult(
         downsampleRatio == DownsampleUtil.DEFAULT_SAMPLE_SIZE
             ? TranscodeStatus.TRANSCODING_NO_RESIZING
-            : TranscodeStatus.TRANSCODING_SUCCESS);
+            : TranscodeStatus.TRANSCODING_SUCCESS,
+        DefaultImageFormats.JPEG);
   }
 
   /**