{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":154201259,"defaultBranch":"main","name":"hermes","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-10-22T19:13:00.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725893210.0","currentOid":""},"activityList":{"items":[{"before":"823992467faffffbf3585fdba995133d649e110a","after":"8ce74afe10bd50c704c30262d62d02488ea6945a","ref":"refs/heads/static_h","pushedAt":"2024-09-20T20:25:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Get FastArray length from backing storage where possible\n\nSummary:\nPrefer getting the FastArray length from the backing ArrayStorage in\ncases where we need to retrieve that storage to load or store a value\nanyway.\n\nThis avoids having to unbox the double (in HV32 mode) and convert the\ndouble length to a uint32.\n\nReviewed By: tmikov\n\nDifferential Revision: D63131049\n\nfbshipit-source-id: 626d67beb54c694fc1d96f911dd8c8392b0de5b1","shortMessageHtmlLink":"Get FastArray length from backing storage where possible"}},{"before":"3def771ade90bb6fffbc83360bd839c18517cce9","after":"823992467faffffbf3585fdba995133d649e110a","ref":"refs/heads/static_h","pushedAt":"2024-09-20T18:23:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove OrderedHashMap::find() from header\n\nSummary: This should have been removed with D61236791, but missed it.\n\nReviewed By: neildhar\n\nDifferential Revision: D63075650\n\nfbshipit-source-id: 0513e2104c2388c5d400402939693011fc763e23","shortMessageHtmlLink":"Remove OrderedHashMap::find() from header"}},{"before":"5afea270395863cc845c02ffcfdba13ede24c08c","after":"3def771ade90bb6fffbc83360bd839c18517cce9","ref":"refs/heads/static_h","pushedAt":"2024-09-20T17:24:51.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Optimise FastArray store bounds check\n\nSummary:\nThe store bounds check for FastArray currently converts the length from\na double to an int and then performs an integer comparison against the\nindex. Instead, directly retrieve the size from the ArrayStorage, as we\ndo for loads.\n\nThis also avoids needing to unbox the length property when HV32 is on.\n\nReviewed By: tmikov\n\nDifferential Revision: D62581590\n\nfbshipit-source-id: 81c93e4c1897d6d17f76cf198de9ef08a0c4fdd5","shortMessageHtmlLink":"Optimise FastArray store bounds check"}},{"before":"45d3069175d2789acf4e062836804ada22b35c8a","after":"5afea270395863cc845c02ffcfdba13ede24c08c","ref":"refs/heads/static_h","pushedAt":"2024-09-20T14:24:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Merge FastArray load paths\n\nSummary:\nMerge the paths for loading from a FastArray since they are both\ncurrently out-of-line.\n\nThis change makes the HV32 case more efficient:\n1. Since we are loading the ArrayStorage pointer anyway, we can do an\ninteger comparison against the length stored in the ArrayStorage instead\nof comparing against the length property which is a double.\n2. Eliminate the unnecessary second bounds check in FastArray::at.\n3. No longer need to check if the length property is an inline double\nand unbox it if it isn't.\n\nReviewed By: tmikov\n\nDifferential Revision: D63002701\n\nfbshipit-source-id: f6af4bbb40d03454024ab5333a4791c2325495b1","shortMessageHtmlLink":"Merge FastArray load paths"}},{"before":"27c50aa9c4c85dd2f58521283a87b19337702554","after":"45d3069175d2789acf4e062836804ada22b35c8a","ref":"refs/heads/static_h","pushedAt":"2024-09-20T04:47:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Disable -fsanitize=function on Apple platforms\n\nSummary:\n`-fsanitize=function` relies on storing data before a function pointer\nthat describes the type of the function. However, on Apple platforms,\nthis data gets treated as part of the preceding function and can be\nmoved around or deleted. This results in UBSan false positives.\n\nTo address this, pass `-fno-sanitize=function` when compiling for Apple\nplatforms with UBSan enabled.\n\nSee https://github.com/llvm/llvm-project/issues/109074\n\nReviewed By: fbmal7\n\nDifferential Revision: D62921741\n\nfbshipit-source-id: da7fe78fc09840c90a48e6dfcf32ed14c514c323","shortMessageHtmlLink":"Disable -fsanitize=function on Apple platforms"}},{"before":"59bb24a70c91e699e7b23926863679f911f0fbf1","after":"27c50aa9c4c85dd2f58521283a87b19337702554","ref":"refs/heads/static_h","pushedAt":"2024-09-20T03:12:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Ensure PointerBase is the first member of DummyRuntime\n\nSummary:\nIn static_h, PointerBase is just an alias for SHRuntime, which is\nnon-empty. This means that it needs to be the first subclass of\nDummyRuntime in order to have the same address.\n\nThis is necessary because contiguous compressed pointers require the\nruntime address to be at the start of the segment.\n\nReviewed By: dannysu, fbmal7\n\nDifferential Revision: D63058943\n\nfbshipit-source-id: afea06f45ec8fad4d6d3ed70f31ffca7753a19d9","shortMessageHtmlLink":"Ensure PointerBase is the first member of DummyRuntime"}},{"before":"655ac1ec97d74ffb60006d979effd8ed18c7b36a","after":"59bb24a70c91e699e7b23926863679f911f0fbf1","ref":"refs/heads/static_h","pushedAt":"2024-09-20T02:06:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deploy 0.246.0 to xplat + www\n\nSummary:\nOriginal Author: alta@meta.com\nOriginal Git: 4796f022eb882e3a5e70960fad5efa647da3a663\nOriginal Reviewed By: SamChou19815\nOriginal Revision: D62763246\n\nX-link: https://github.com/facebook/react-native/pull/46519\n\nChangelog: [Internal]\n\nReviewed By: tmikov\n\nDifferential Revision: D62971382\n\nfbshipit-source-id: 6e741d0584d8e4ca5cc90663d6785211af6aa068","shortMessageHtmlLink":"Deploy 0.246.0 to xplat + www"}},{"before":"6dc33b557eb0922bce7c2036612f9822f21e503f","after":"655ac1ec97d74ffb60006d979effd8ed18c7b36a","ref":"refs/heads/static_h","pushedAt":"2024-09-18T23:37:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add checks instead of asserts for variable counts\n\nSummary:\nIt's possible to have callstacks that are interspersed with CodeBlocks\nthat have no variable information, so handle this explicitly instead of\nasserting that it's always there.\n\nReviewed By: neildhar\n\nDifferential Revision: D62903914\n\nfbshipit-source-id: e01b8341754f7ae276d045552410e4570f16b202","shortMessageHtmlLink":"Add checks instead of asserts for variable counts"}},{"before":"a75e14a1d485521a2cda1baad86944e4de86e5c2","after":"4796f022eb882e3a5e70960fad5efa647da3a663","ref":"refs/heads/main","pushedAt":"2024-09-17T22:10:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deploy 0.246.0 to xplat + www\n\nSummary:\nX-link: https://github.com/facebook/react-native/pull/46519\n\nChangelog: [Internal]\n\nReviewed By: SamChou19815\n\nDifferential Revision: D62763246\n\nfbshipit-source-id: db0296d9ec5c04374c9cacb947b4879671044264","shortMessageHtmlLink":"Deploy 0.246.0 to xplat + www"}},{"before":"8b70a668fb547d646dd3a4f9ec5c5ab1235cb2ea","after":"6dc33b557eb0922bce7c2036612f9822f21e503f","ref":"refs/heads/static_h","pushedAt":"2024-09-17T21:19:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix: signDisplay plus sign behaviour fixed for NumberFormat (#1483) (#1483)\n\nSummary:\nOriginal Author: 85783070+shubhamguptadream11@users.noreply.github.com\nOriginal Git: a75e14a1d485521a2cda1baad86944e4de86e5c2\nOriginal Reviewed By: avp\nOriginal Revision: D62153166\n\nFixes following issue:\n- https://github.com/facebook/hermes/issues/1466\n- https://github.com/facebook/hermes/issues/1138\n- https://github.com/facebook/hermes/issues/789\n\n**Why this change is made?**\n\nThere are few cases where signDisplay is not being handled correctly.\nExamples:\n```\n1.\nnew Intl.NumberFormat('de-DE', {\n style: 'currency',\n currency: 'EUR',\n signDisplay: 'exceptZero',\n}).format(8537.71)\n\nOutput: +8,537,71+\nExpected: +8.537,71 €\n\n2.\nnew Intl.NumberFormat('ja-JP', {\n style: 'currency',\n currency: 'JPY',\n signDisplay: 'exceptZero'\n}).format(123456.789)\n\nOutput: +123,457\nExpected: +￥123,457\n```\n\n**ChangeLog**\n\nThis PR updates the implementation and testing of the signDisplay functionality in the DecimalFormat class within the Hermes engine, specifically for Android API level 31 and above.\n\n**Key Changes:**\n\nImplementation:\n- Integrated the **setSignAlwaysShown** method of DecimalFormat for API level 31 and above to control the display of the sign (+ or -) based on the signDisplay option. [For more detail about setSignAlwaysShown check [here](https://developer.android.com/reference/android/icu/text/DecimalFormat#setSignAlwaysShown(boolean))]\n- For API levels below 31, maintained the existing logic for handling sign display, ensuring backward compatibility.\n\nPull Request resolved: https://github.com/facebook/hermes/pull/1483\n\nPulled By: neildhar\n\nReviewed By: neildhar\n\nDifferential Revision: D62883944\n\nfbshipit-source-id: df41029b45400b9db038f32727293d5ccda27211","shortMessageHtmlLink":"fix: signDisplay plus sign behaviour fixed for NumberFormat (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2471379413\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/hermes/issues/1483\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/hermes/pull/1483/hovercard\" href=\"https://github.com/facebook/hermes/pull/1483\">#1483</a>) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2471379413\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/hermes/issues/1483\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/hermes/pull/1483/hovercard\" href=\"https://github.com/facebook/hermes/pull/1483\">#…</a>"}},{"before":"2ca5da296ae92b4557beec658ac60cadb76f2461","after":"a75e14a1d485521a2cda1baad86944e4de86e5c2","ref":"refs/heads/main","pushedAt":"2024-09-17T15:50:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix: signDisplay plus sign behaviour fixed for NumberFormat (#1483)\n\nSummary:\nFixes following issue:\n- https://github.com/facebook/hermes/issues/1466\n- https://github.com/facebook/hermes/issues/1138\n- https://github.com/facebook/hermes/issues/789\n\n**Why this change is made?**\n\nThere are few cases where signDisplay is not being handled correctly.\nExamples:\n```\n1.\nnew Intl.NumberFormat('de-DE', {\n style: 'currency',\n currency: 'EUR',\n signDisplay: 'exceptZero',\n}).format(8537.71)\n\nOutput: +8,537,71+\nExpected: +8.537,71 €\n\n2.\nnew Intl.NumberFormat('ja-JP', {\n style: 'currency',\n currency: 'JPY',\n signDisplay: 'exceptZero'\n}).format(123456.789)\n\nOutput: +123,457\nExpected: +￥123,457\n```\n\n**ChangeLog**\n\nThis PR updates the implementation and testing of the signDisplay functionality in the DecimalFormat class within the Hermes engine, specifically for Android API level 31 and above.\n\n**Key Changes:**\n\nImplementation:\n- Integrated the **setSignAlwaysShown** method of DecimalFormat for API level 31 and above to control the display of the sign (+ or -) based on the signDisplay option. [For more detail about setSignAlwaysShown check [here](https://developer.android.com/reference/android/icu/text/DecimalFormat#setSignAlwaysShown(boolean))]\n- For API levels below 31, maintained the existing logic for handling sign display, ensuring backward compatibility.\n\nPull Request resolved: https://github.com/facebook/hermes/pull/1483\n\nTest Plan:\n- Added a comprehensive set of test cases in **HermesIntlAndroidTest.java** to validate the behaviour of the signDisplay functionality, specifically for API level 31 and above.\n- Test cases cover scenarios for signDisplay: `NEVER | ALWAYS | EXCEPTZERO`\n\nReviewed By: avp\n\nDifferential Revision: D62153166\n\nPulled By: neildhar\n\nfbshipit-source-id: d45c55ae7ffbfbc38ec4b331339859b8c96486c7","shortMessageHtmlLink":"fix: signDisplay plus sign behaviour fixed for NumberFormat (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2471379413\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/hermes/issues/1483\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/hermes/pull/1483/hovercard\" href=\"https://github.com/facebook/hermes/pull/1483\">#1483</a>)"}},{"before":"649ceaa4c8b2ed331251152ccb7fcee07f19fc4c","after":"2ca5da296ae92b4557beec658ac60cadb76f2461","ref":"refs/heads/main","pushedAt":"2024-09-17T00:17:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Don't allow newline after async in method property\n\nSummary:\nA newline should not be allowed between `async` and `function` when\nusing method syntax. Verify this by checking\n`isNewLineBeforeCurrentToken`.\n\nReviewed By: tmikov\n\nDifferential Revision: D62671336\n\nfbshipit-source-id: aa47fbfe24a5b93098188dc5bc7cd3afa1013335","shortMessageHtmlLink":"Don't allow newline after async in method property"}},{"before":"15c90648a5b0feb211123efa1c6d6276e6d3118a","after":"8b70a668fb547d646dd3a4f9ec5c5ab1235cb2ea","ref":"refs/heads/static_h","pushedAt":"2024-09-17T00:08:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add lazy/eval doc\n\nSummary:\nA first pass at some explanation of how the whole thing works.\n\nIt can be improved on but it at least lists the biggest sections.\n\nReviewed By: tmikov\n\nDifferential Revision: D62769055\n\nfbshipit-source-id: d1a7bc2061e05587090adaf803298830c35c9d02","shortMessageHtmlLink":"Add lazy/eval doc"}},{"before":"0b87f235f537cc02e6d51070f71762ab1b81fca1","after":"15c90648a5b0feb211123efa1c6d6276e6d3118a","ref":"refs/heads/static_h","pushedAt":"2024-09-14T18:04:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"typed: exact object properties were stored twice (#1520)\n\nSummary:\nPull Request resolved: https://github.com/facebook/hermes/pull/1520\n\nThere was a missing `return` in IRGen.\n\nReviewed By: avp\n\nDifferential Revision: D62676445\n\nfbshipit-source-id: 4d743bde9f6372cb14b985e16a3b28a3fc4f2f15","shortMessageHtmlLink":"typed: exact object properties were stored twice (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2525939152\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/hermes/issues/1520\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/hermes/pull/1520/hovercard\" href=\"https://github.com/facebook/hermes/pull/1520\">#1520</a>)"}},{"before":"4ed4f364120a6a21f735aa11496c3d338c65be2e","after":"0b87f235f537cc02e6d51070f71762ab1b81fca1","ref":"refs/heads/static_h","pushedAt":"2024-09-13T23:54:53.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Harden the trace intepreter so it doesn't access records that don't exist.\n\nSummary:\nOriginal Author: ddetlefs@meta.com\nOriginal Git: 649ceaa4c8b2ed331251152ccb7fcee07f19fc4c\nOriginal Reviewed By: mattbfb\nOriginal Revision: D61546894\n\nI (ddetlefs) created a trace.  At the time I did this, there was a problem with the trace fixup tool, so I fixed up the trace by hand, removing the incomplete last record.  When I ran it, the trace interpreter crashed.  I figured out that this was from accessing the records vector out of bounds.\n\nWhile we have also fixed the fixup-tool to walk back to \"last empty stack\", we decided it would also be good to harden the TraceInterpreter against such crashes.  I by considering where \"records\" is accessed, I identified 3 such places.  This diff fixes them, in both the hermes and static_h copies of TraceInterpreter.cpp.\n\nReviewed By: davedets\n\nDifferential Revision: D62456472\n\nfbshipit-source-id: 777c4517bf5c0e43cdbe7c0dea71b79b13d04de2","shortMessageHtmlLink":"Harden the trace intepreter so it doesn't access records that don't e…"}},{"before":"f15c1aceae57dae3df2301247f45db8d5a9fba38","after":"4ed4f364120a6a21f735aa11496c3d338c65be2e","ref":"refs/heads/static_h","pushedAt":"2024-09-13T01:01:22.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove OrderedHashMap::find()\n\nSummary:\n`find()` exposes internal storage detail `BucketType *`, which hinders\nfuture change to how data is stored. The `get()` function serves the\nsame need.\n\nReviewed By: neildhar\n\nDifferential Revision: D61236791\n\nfbshipit-source-id: 7110d4663ea5a5d8a16a6badc16535f2e37c6051","shortMessageHtmlLink":"Remove OrderedHashMap::find()"}},{"before":"16c035171bdd4871f1bfdafd88d9fd3d9ec1687a","after":"f15c1aceae57dae3df2301247f45db8d5a9fba38","ref":"refs/heads/static_h","pushedAt":"2024-09-12T19:45:10.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"JIT: Add instanceof\n\nReviewed By: tmikov\n\nDifferential Revision: D62591376\n\nfbshipit-source-id: 4bee19574b42ed7115438c7a6d9fbe6e4a70f0dd","shortMessageHtmlLink":"JIT: Add instanceof"}},{"before":"d2c4f3dfea4a80fad682c744f23fb14be8eb6ce8","after":"16c035171bdd4871f1bfdafd88d9fd3d9ec1687a","ref":"refs/heads/static_h","pushedAt":"2024-09-12T17:05:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add a timeout to SerialExecutor\n\nSummary:\nAdd support for a timeout in SerialExecutor so we can limit how long\nthe thread is cached for.\n\nReviewed By: fbmal7\n\nDifferential Revision: D61301498\n\nfbshipit-source-id: 004bce356d25f92aeb0373e7b341fdd8ae96b0a9","shortMessageHtmlLink":"Add a timeout to SerialExecutor"}},{"before":"cc8655f2b28dcddc9a6ed4181114138fe90507c5","after":"d2c4f3dfea4a80fad682c744f23fb14be8eb6ce8","ref":"refs/heads/static_h","pushedAt":"2024-09-11T22:54:50.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"JIT: Be consistent in \"HW\" usage in function names.\n\nSummary:\nThis wasn't confusing, it just annoyed me that sometimes it's `HWReg`\nbut sometimes it's `HW`.\n\nReviewed By: tmikov\n\nDifferential Revision: D62473511\n\nfbshipit-source-id: cefd6f0c1b9846dc3e4210dcecf3f92dae4caa2c","shortMessageHtmlLink":"JIT: Be consistent in \"HW\" usage in function names."}},{"before":"0ef1c114edcc4b6240550a3d6ec595b3b5e59119","after":"cc8655f2b28dcddc9a6ed4181114138fe90507c5","ref":"refs/heads/static_h","pushedAt":"2024-09-11T22:32:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"jit: pass regalloc ranges to the emitter\n\nSummary: .\n\nReviewed By: avp\n\nDifferential Revision: D62523858\n\nfbshipit-source-id: 1f0dd92d8c87e7d890727b6343ff6837fcd7c23f","shortMessageHtmlLink":"jit: pass regalloc ranges to the emitter"}},{"before":"2dcc308b984b94de0f2d22616f45757c04311ef1","after":"0ef1c114edcc4b6240550a3d6ec595b3b5e59119","ref":"refs/heads/static_h","pushedAt":"2024-09-11T21:37:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add total instructions to profile output.\n\nSummary: For optimizations that should decrease total number of bytecodes executed, it would be useful to be able to obtain that number fairly easily.   This diff adds that total to the output of the \"function\" command in hbcdump.\n\nReviewed By: avp\n\nDifferential Revision: D61821570\n\nfbshipit-source-id: 1f8565328cf1a12b4fe137e5e46b7e8fd1a29a09","shortMessageHtmlLink":"Add total instructions to profile output."}},{"before":"7c2d875355cc9c691ffd35ede2b44b6c384cfbb1","after":"2dcc308b984b94de0f2d22616f45757c04311ef1","ref":"refs/heads/static_h","pushedAt":"2024-09-11T18:19:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reject static fields named 'prototype' in parser\n\nSummary:\nStatic fields that are named 'prototype' should not be allowed,\naccording to the spec. Static methods are already correctly being\nchecked in the parser. Relevant spec:\nhttps://tc39.es/ecma262/#sec-class-definitions-static-semantics-early-errors\n\nReviewed By: avp\n\nDifferential Revision: D62148870\n\nfbshipit-source-id: 75335188a3706ff21e24659615eba63c9dd5bb14","shortMessageHtmlLink":"Reject static fields named 'prototype' in parser"}},{"before":"04ed3e796b7f9bfd7625adc987ecbf4c237629e4","after":"7c2d875355cc9c691ffd35ede2b44b6c384cfbb1","ref":"refs/heads/static_h","pushedAt":"2024-09-11T11:44:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Lazily create thread in SerialExecutor\n\nSummary:\nCreate the SerialExecutor thread lazily when the first task is enqueued\ninstead of doing it eagerly upon construction. This will make it easier\nto support destroying and recreating the thread in the next diff.\n\nReviewed By: fbmal7\n\nDifferential Revision: D61567077\n\nfbshipit-source-id: aae33cb2286e5038894895350f8e764062613818","shortMessageHtmlLink":"Lazily create thread in SerialExecutor"}},{"before":"574302364ebbef5ca7d59f5e8b44eab8ba36b281","after":"04ed3e796b7f9bfd7625adc987ecbf4c237629e4","ref":"refs/heads/static_h","pushedAt":"2024-09-10T20:19:10.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reenable codegen tests\n\nReviewed By: neildhar\n\nDifferential Revision: D61505606\n\nfbshipit-source-id: 003cbd259f9a3e3ba0e87a10a9f6ca8d4b4833e6","shortMessageHtmlLink":"Reenable codegen tests"}},{"before":"3f4aecff776915b708f155d1b320149c09af2663","after":"574302364ebbef5ca7d59f5e8b44eab8ba36b281","ref":"refs/heads/static_h","pushedAt":"2024-09-10T01:47:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"jit: syncToMem() global registers before jCond slow path\n\nSummary: .\n\nReviewed By: neildhar\n\nDifferential Revision: D62357770\n\nfbshipit-source-id: c5a56c4a9a809705485b861497b05cadcaa4f885","shortMessageHtmlLink":"jit: syncToMem() global registers before jCond slow path"}},{"before":"840e54b3426a530e903701f1665b6deab74ea4e6","after":"3f4aecff776915b708f155d1b320149c09af2663","ref":"refs/heads/static_h","pushedAt":"2024-09-09T23:13:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Harden the trace intepreter so it doesn't access records that don't exist.\n\nSummary:\nI (ddetlefs) created a trace.  At the time I did this, there was a problem with the trace fixup tool, so I fixed up the trace by hand, removing the incomplete last record.  When I ran it, the trace interpreter crashed.  I figured out that this was from accessing the records vector out of bounds.\n\nWhile we have also fixed the fixup-tool to walk back to \"last empty stack\", we decided it would also be good to harden the TraceInterpreter against such crashes.  I by considering where \"records\" is accessed, I identified 3 such places.  This diff fixes them, in both the hermes and static_h copies of TraceInterpreter.cpp.\n\nReviewed By: mattbfb\n\nDifferential Revision: D61546894\n\nfbshipit-source-id: c6a99b2631b16913b07956912914c3803f91a15c","shortMessageHtmlLink":"Harden the trace intepreter so it doesn't access records that don't e…"}},{"before":"c4767b0784badb1cbcfcd98aab9fb6f9481d5abb","after":"649ceaa4c8b2ed331251152ccb7fcee07f19fc4c","ref":"refs/heads/main","pushedAt":"2024-09-09T23:13:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Harden the trace intepreter so it doesn't access records that don't exist.\n\nSummary:\nI (ddetlefs) created a trace.  At the time I did this, there was a problem with the trace fixup tool, so I fixed up the trace by hand, removing the incomplete last record.  When I ran it, the trace interpreter crashed.  I figured out that this was from accessing the records vector out of bounds.\n\nWhile we have also fixed the fixup-tool to walk back to \"last empty stack\", we decided it would also be good to harden the TraceInterpreter against such crashes.  I by considering where \"records\" is accessed, I identified 3 such places.  This diff fixes them, in both the hermes and static_h copies of TraceInterpreter.cpp.\n\nReviewed By: mattbfb\n\nDifferential Revision: D61546894\n\nfbshipit-source-id: c6a99b2631b16913b07956912914c3803f91a15c","shortMessageHtmlLink":"Harden the trace intepreter so it doesn't access records that don't e…"}},{"before":"b3c7f8f9a2806b04a6e40d135964a5be4963cdc9","after":"840e54b3426a530e903701f1665b6deab74ea4e6","ref":"refs/heads/static_h","pushedAt":"2024-09-09T19:59:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"JIT: AddEmptyString\n\nReviewed By: neildhar\n\nDifferential Revision: D62254183\n\nfbshipit-source-id: 0158ed264e92d6a7aae2df185d80dfb848e726e0","shortMessageHtmlLink":"JIT: AddEmptyString"}},{"before":"db6d12e202e15f7a446d8848d6ca8f7abb3cfb32","after":"c4767b0784badb1cbcfcd98aab9fb6f9481d5abb","ref":"refs/heads/main","pushedAt":"2024-09-09T16:10:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update create-tag.yml for Hermes (#1514)\n\nSummary:\nThis is just a nit because this string is not entirely correct.\n\nPull Request resolved: https://github.com/facebook/hermes/pull/1514\n\nTest Plan: Nothing to test\n\nReviewed By: cipolleschi\n\nDifferential Revision: D62381946\n\nPulled By: cortinico\n\nfbshipit-source-id: 643aab29fc3f4fc8532f7e2d545b5a1c0844db5b","shortMessageHtmlLink":"Update create-tag.yml for Hermes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2514179983\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/hermes/issues/1514\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/hermes/pull/1514/hovercard\" href=\"https://github.com/facebook/hermes/pull/1514\">#1514</a>)"}},{"before":null,"after":"c84264db41302aac85ec79e1e2bcc56081c82d71","ref":"refs/heads/cortinico-patch-1","pushedAt":"2024-09-09T14:46:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"cortinico","name":"Nicola Corti","path":"/cortinico","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3001957?s=80&v=4"},"commit":{"message":"Update create-tag.yml for Hermes","shortMessageHtmlLink":"Update create-tag.yml for Hermes"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMFQyMDoyNTozNy4wMDAwMDBazwAAAAS8WDlK","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMFQyMDoyNTozNy4wMDAwMDBazwAAAAS8WDlK","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wOVQxNDo0Njo1MC4wMDAwMDBazwAAAASxBqIB"}},"title":"Activity · facebook/hermes"}