Skip to content

Commit a15aff6

Browse files
committed
Fix trivial OSS test failures
Address some straightforward test failures in HHVM OSS: * Gate tests for internal Meta extensions behind appropriate runif checks. * Set -vPHP7.EngineExceptions=false for some tests that assume this, as this knob defaults to false in internal builds but to true in OSS. * Skip tests that exercise fb_(un)serialize() outside internal builds, since FBSerialize was removed from HHVM OSS in D46525242.
1 parent 8b0a654 commit a15aff6

26 files changed

+151
-1
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
-vPHP7.EngineExceptions=false
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<<__EntryPoint>>
2+
function skipif(): void {
3+
if (!HHVM_FACEBOOK) {
4+
exit('skip fb_serialize() not available in OSS');
5+
}
6+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?hh
2+
3+
<<__EntryPoint>>
4+
function skipif(): void {
5+
if (!HHVM_FACEBOOK) {
6+
exit('skip fb_serialize() not available in OSS');
7+
}
8+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?hh
2+
3+
<<__EntryPoint>>
4+
function skipif(): void {
5+
if (!HHVM_FACEBOOK) {
6+
exit('skip fb_serialize() not available in OSS');
7+
}
8+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?hh
2+
3+
<<__EntryPoint>>
4+
function skipif(): void {
5+
if (!HHVM_FACEBOOK) {
6+
exit('skip fb_serialize() not available in OSS');
7+
}
8+
}

hphp/test/slow/eden/config.runif

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
extension eden
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
extension configerator
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?hh
2+
3+
<<__EntryPoint>>
4+
function skipif(): void {
5+
if (!HHVM_FACEBOOK) {
6+
exit('skip fb_serialize() not available in OSS');
7+
}
8+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?hh
2+
3+
<<__EntryPoint>>
4+
function skipif(): void {
5+
if (!HHVM_FACEBOOK) {
6+
exit('skip fb_serialize() not available in OSS');
7+
}
8+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?hh
2+
3+
<<__EntryPoint>>
4+
function skipif(): void {
5+
if (!HHVM_FACEBOOK) {
6+
exit('skip fb_serialize() not available in OSS');
7+
}
8+
}

0 commit comments

Comments
 (0)