Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run build_helper.sh with some errors in QuicFizzFactory.cpp #222

Open
longmao121 opened this issue Oct 28, 2021 · 2 comments
Open

run build_helper.sh with some errors in QuicFizzFactory.cpp #222

longmao121 opened this issue Oct 28, 2021 · 2 comments

Comments

@longmao121
Copy link

20.04.1 LTS
gcc --version 9.3.0
I ran ./build_helper.sh and the error messages are below:

[ 9%] No install step for 'googletest'
[ 9%] Completed 'googletest'
[ 11%] Built target googletest
[ 13%] Built target PacketNumberTest
[ 14%] Built target PacketNumberCipherTest
Scanning dependencies of target QuicConnectionIdTest
[ 15%] Building CXX object quic/codec/test/CMakeFiles/QuicConnectionIdTest.dir/QuicConnectionIdTest.cpp.o
[ 15%] Building CXX object quic/codec/test/CMakeFiles/QuicConnectionIdTest.dir///common/test/TestMain.cpp.o
/home/longmao/Documents/mvfst/quic/handshake/QuicFizzFactory.cpp:17:37: error: ‘folly::Optionalfizz::TLSMessage {anonymous}::QuicPlaintextReadRecordLayer::read(folly::IOBufQueue&)’ marked ‘override’, but does not override
17 | folly::Optionalfizz::TLSMessage read(folly::IOBufQueue& buf) override {
| ^~~~
/home/longmao/Documents/mvfst/quic/handshake/QuicFizzFactory.cpp:17:37: warning: by ‘folly::Optionalfizz::TLSMessage {anonymous}::QuicPlaintextReadRecordLayer::read(folly::IOBufQueue&)’ [-Woverloaded-virtual]
/home/longmao/Documents/mvfst/quic/handshake/QuicFizzFactory.cpp:35:37: error: ‘folly::Optionalfizz::TLSMessage {anonymous}::QuicEncryptedReadRecordLayer::read(folly::IOBufQueue&)’ marked ‘override’, but does not override
35 | folly::Optionalfizz::TLSMessage read(folly::IOBufQueue& buf) override {
| ^~~~
/home/longmao/Documents/mvfst/quic/handshake/QuicFizzFactory.cpp:35:37: warning: by ‘folly::Optionalfizz::TLSMessage {anonymous}::QuicEncryptedReadRecordLayer::read(folly::IOBufQueue&)’ [-Woverloaded-virtual]
/home/longmao/Documents/mvfst/quic/handshake/QuicFizzFactory.cpp:50:20: error: ‘fizz::TLSContent {anonymous}::QuicPlaintextWriteRecordLayer::write(fizz::TLSMessage&&) const’ marked ‘override’, but does not override
50 | fizz::TLSContent write(fizz::TLSMessage&& msg) const override {
| ^~~~~
/home/longmao/Documents/mvfst/quic/handshake/QuicFizzFactory.cpp:50:20: warning: by ‘fizz::TLSContent {anonymous}::QuicPlaintextWriteRecordLayer::write(fizz::TLSMessage&&) const’ [-Woverloaded-virtual]
/home/longmao/Documents/mvfst/quic/handshake/QuicFizzFactory.cpp:72:20: error: ‘fizz::TLSContent {anonymous}::QuicEncryptedWriteRecordLayer::write(fizz::TLSMessage&&) const’ marked ‘override’, but does not override
72 | fizz::TLSContent write(fizz::TLSMessage&& msg) const override {
| ^~~~~
/home/longmao/Documents/mvfst/quic/handshake/QuicFizzFactory.cpp:72:20: warning: by ‘fizz::TLSContent {anonymous}::QuicEncryptedWriteRecordLayer::write(fizz::TLSMessage&&) const’ [-Woverloaded-virtual]
[ 15%] Linking CXX executable QuicConnectionIdTest
make[2]: *** [quic/handshake/CMakeFiles/mvfst_handshake.dir/build.make:115: quic/handshake/CMakeFiles/mvfst_handshake.dir/QuicFizzFactory.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3109: quic/handshake/CMakeFiles/mvfst_handshake.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 15%] Built target QuicConnectionIdTest
make: *** [Makefile:141: all] Error 2

image

@Yangbin-v
Copy link

Hello, have your problem been solved? I have the same problem.

@Yangbin-v
Copy link

@longmao121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants