fix Error when calling abstract method on super() #1358 #1363
Conversation
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D85364483. |
| .map(|(idx, range)| (self.get_idx(*idx).arc_clone_ty(), *range)), | ||
| ); | ||
|
|
||
| if stub_or_impl == FunctionStubOrImpl::Stub { |
There was a problem hiding this comment.
Note: the name FunctionStubOrImpl::Stub is preexisting and goes against my request, but we can probably live with it for now - I may try to rename it later.
But related: @yangdanny97 do you know what happens if this is actually a "stub" in the sense of coming from a .pyi file?
In particular - will an actual stub from a .pyi file always have FunctionStubOrImpl::Impl rather than FunctionStubOrImpl::Stub?
It would be wrong for a stub to ever use Stub (that sentence explains exactly why the name Stub is probably the wrong name haha!), since for stubs we have to assume they imply an implementation exists, typically in native code.
We might want to add a test for that if we're not sure - this could throw a lot of false positives on actual .pyi files if we get it wrong
There was a problem hiding this comment.
pyrefly/pyrefly/lib/binding/function.rs
Line 477 in 01f0a29
This is where it's set, I don't think it considers the type of module, only whether it has a proper body or not.
3 participants
fix #1358