From 1a6892a23c4c2826ce3fc533a431f009e68c9685 Mon Sep 17 00:00:00 2001 From: Ruslan Lesiutin <28902667+hoxyq@users.noreply.github.com> Date: Wed, 7 Jan 2026 22:31:01 +0000 Subject: [PATCH] Revert "Add FB only network event coverage notice (#228)" This reverts commit c85f7e933aa685da64ee73e398bf06d33d9d2f3c. --- config/gni/devtools_grd_files.gni | 2 - front_end/global_typings/react_native.d.ts | 2 - front_end/panels/network/NetworkLogView.ts | 13 --- front_end/panels/network/components/BUILD.gn | 2 - .../NetworkEventCoverageInfobar.css | 61 ------------ .../components/NetworkEventCoverageInfobar.ts | 99 ------------------- .../panels/network/components/components.ts | 2 - .../ui/visual_logging/KnownContextValues.ts | 1 - .../eslint_rules/lib/check-license-header.js | 1 - 9 files changed, 183 deletions(-) delete mode 100644 front_end/panels/network/components/NetworkEventCoverageInfobar.css delete mode 100644 front_end/panels/network/components/NetworkEventCoverageInfobar.ts diff --git a/config/gni/devtools_grd_files.gni b/config/gni/devtools_grd_files.gni index 80df96a7e71..317517f56b0 100644 --- a/config/gni/devtools_grd_files.gni +++ b/config/gni/devtools_grd_files.gni @@ -1654,8 +1654,6 @@ grd_files_debug_sources = [ "front_end/panels/network/components/EditableSpan.js", "front_end/panels/network/components/HeaderSectionRow.css.js", "front_end/panels/network/components/HeaderSectionRow.js", - "front_end/panels/network/components/NetworkEventCoverageInfobar.css.js", - "front_end/panels/network/components/NetworkEventCoverageInfobar.js", "front_end/panels/network/components/RequestHeaderSection.css.js", "front_end/panels/network/components/RequestHeaderSection.js", "front_end/panels/network/components/RequestHeadersView.css.js", diff --git a/front_end/global_typings/react_native.d.ts b/front_end/global_typings/react_native.d.ts index 275a1092d5c..bb026253b2f 100644 --- a/front_end/global_typings/react_native.d.ts +++ b/front_end/global_typings/react_native.d.ts @@ -21,7 +21,5 @@ declare global { var reactNativeOpenInEditorButtonImage: string|undefined; // eslint-disable-next-line no-var,@typescript-eslint/naming-convention var FB_ONLY__reactNativeFeedbackLink: string|undefined; - // eslint-disable-next-line no-var,@typescript-eslint/naming-convention - var FB_ONLY__enableNetworkCoverageNotice: boolean|undefined; } } diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts index 61869aa0db9..876a633bb8f 100644 --- a/front_end/panels/network/NetworkLogView.ts +++ b/front_end/panels/network/NetworkLogView.ts @@ -65,7 +65,6 @@ import { type NetworkNode, NetworkRequestNode, } from './NetworkDataGridNode.js'; -import './components/NetworkEventCoverageInfobar.js'; import {NetworkFrameGrouper} from './NetworkFrameGrouper.js'; import networkLogViewStyles from './networkLogView.css.js'; import {NetworkLogViewColumns} from './NetworkLogViewColumns.js'; @@ -572,12 +571,6 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin(DISMISSED_SETTING_NAME, false); - - connectedCallback(): void { - this.#shadow.adoptedStyleSheets = [networkEventCoverageInfobarStyles]; - this.#render(); - } - - #onToggleExpand(): void { - this.#expanded = !this.#expanded; - this.#render(); - } - - #onClose(event: Event): void { - event.stopPropagation(); - this.#dismissedSetting.set(true); - this.#render(); - } - - #render(): void { - if (this.#dismissedSetting.get()) { - Lit.render(Lit.nothing, this.#shadow, {host: this}); - return; - } - // clang-format off - Lit.render( - html` -
-
{ - if (e.key === 'Enter' || e.key === ' ') { - e.preventDefault(); - this.#onToggleExpand(); - } - }} - jslog=${VisualLogging.expand().track({click: true})} - > - - - [FB-only] Network event coverage - -
- ${this.#expanded ? html` -
- Only fetch() and XMLHttpRequest events are available at Meta. Images fetched via <Image> are not currently supported. -
- ` : Lit.nothing} -
- `, - this.#shadow, - {host: this}, - ); - // clang-format on - } -} - -customElements.define('devtools-network-event-coverage-infobar', NetworkEventCoverageInfobar); - -declare global { - interface HTMLElementTagNameMap { - 'devtools-network-event-coverage-infobar': NetworkEventCoverageInfobar; - } -} diff --git a/front_end/panels/network/components/components.ts b/front_end/panels/network/components/components.ts index cb27e53bf1b..c2debb6873d 100644 --- a/front_end/panels/network/components/components.ts +++ b/front_end/panels/network/components/components.ts @@ -4,7 +4,6 @@ import * as EditableSpan from './EditableSpan.js'; import * as HeaderSectionRow from './HeaderSectionRow.js'; -import * as NetworkEventCoverageInfobar from './NetworkEventCoverageInfobar.js'; import * as RequestHeaderSection from './RequestHeaderSection.js'; import * as RequestHeadersView from './RequestHeadersView.js'; import * as RequestTrustTokensView from './RequestTrustTokensView.js'; @@ -14,7 +13,6 @@ import * as WebBundleInfoView from './WebBundleInfoView.js'; export { EditableSpan, HeaderSectionRow, - NetworkEventCoverageInfobar, RequestHeaderSection, RequestHeadersView, RequestTrustTokensView, diff --git a/front_end/ui/visual_logging/KnownContextValues.ts b/front_end/ui/visual_logging/KnownContextValues.ts index 92cfb7fb450..c1eb4fcbe0c 100644 --- a/front_end/ui/visual_logging/KnownContextValues.ts +++ b/front_end/ui/visual_logging/KnownContextValues.ts @@ -2434,7 +2434,6 @@ export const knownContextValues = new Set([ 'network-conditions.network-mid-tier-mobile', 'network-conditions.network-offline', 'network-conditions.network-online', - 'network-event-coverage-infobar', 'network-event-source-message-filter', 'network-film-strip', 'network-hide-chrome-extensions', diff --git a/scripts/eslint_rules/lib/check-license-header.js b/scripts/eslint_rules/lib/check-license-header.js index 44a7ff10a26..3d6dff28525 100644 --- a/scripts/eslint_rules/lib/check-license-header.js +++ b/scripts/eslint_rules/lib/check-license-header.js @@ -83,7 +83,6 @@ const META_CODE_PATHS = [ 'entrypoints/shell/browser_compatibility_guard.ts', 'global_typings/react_native.d.ts', 'models/react_native', - 'panels/network/components/NetworkEventCoverageInfobar.ts', 'panels/react_devtools', 'panels/rn_welcome', 'panels/timeline/ReactNativeTimelineLandingPage.ts',