Commit a034841
Fix likely bug in maintainVisibleContentPosition (#54363)
Summary:
Pull Request resolved: #54363
The calculus for active scroll maintainVisibleContentPosition is not isomorphic between ReactHorizontalScrollView and ReactScrollView. Additiionally, it doesn't make sense that we would use an x-offset in a y-offset calculation. This fixes a likely bug where the OverScroller's x-offset is used to compute the scroll animation update in ReactScrollView.recreateFlingAnimation.
## Changelog
[Android][Fixed] - Issue with restarting scroll in maintainVisibleContentPosition
Reviewed By: javache
Differential Revision: D86021007
fbshipit-source-id: 0d7febcbccd59df534bacbba7f1b5bb5085fa95f1 parent 19d87c8 commit a034841
File tree
1 file changed
+1
-1
lines changed- packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1367 | 1367 | | |
1368 | 1368 | | |
1369 | 1369 | | |
1370 | | - | |
| 1370 | + | |
1371 | 1371 | | |
1372 | 1372 | | |
1373 | 1373 | | |
| |||
0 commit comments