Remove leaked module provider maps (#54095)

Summary:
Pull Request resolved: #54095

No need for fragile leaked data structures when most of the time we're comparing less than 5 elements and can just do a few inline string comparisons.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D84198064

fbshipit-source-id: 5f8638f78e7be0a9894e0176ec6825d390123a2f

Author: javache

packages/react-native/Libraries/Blob/RCTBlobPlugins.mm

@@ -13,21 +13,21 @@
 
 #import "RCTBlobPlugins.h"
 
-#import <string>
-#import <unordered_map>
-
-Class RCTBlobClassProvider(const char *name) {
-  // Intentionally leak to avoid crashing after static destructors are run.
-  static const auto sCoreModuleClassMap = new const std::unordered_map<std::string, Class (*)(void)>{
-    {"BlobModule", RCTBlobManagerCls},
-    {"FileReaderModule", RCTFileReaderModuleCls},
-  };
-
-  auto p = sCoreModuleClassMap->find(name);
-  if (p != sCoreModuleClassMap->end()) {
-    auto classFunc = p->second;
-    return classFunc();
+#import <string_view>
+
+using namespace std::literals;
+
+Class RCTBlobClassProvider(const char *name)
+{
+
+  if (name == "BlobModule"sv) {
+    return RCTBlobManagerCls();
   }
+
+  if (name == "FileReaderModule"sv) {
+    return RCTFileReaderModuleCls();
+  }
+
   return nil;
 }
 

packages/react-native/Libraries/Image/RCTImagePlugins.h

@@ -29,6 +29,7 @@ extern "C" {
 Class RCTImageClassProvider(const char *name);
 
 // Lookup functions
+Class RCTBundleAssetImageLoaderCls(void) __attribute__((used));
 Class RCTGIFImageDecoderCls(void) __attribute__((used));
 Class RCTImageEditingManagerCls(void) __attribute__((used));
 Class RCTImageLoaderCls(void) __attribute__((used));

packages/react-native/Libraries/Image/RCTImagePlugins.mm

@@ -13,24 +13,37 @@
 
 #import "RCTImagePlugins.h"
 
-#import <string>
-#import <unordered_map>
-
-Class RCTImageClassProvider(const char *name) {
-  // Intentionally leak to avoid crashing after static destructors are run.
-  static const auto sCoreModuleClassMap = new const std::unordered_map<std::string, Class (*)(void)>{
-    {"GIFImageDecoder", RCTGIFImageDecoderCls},
-    {"ImageEditingManager", RCTImageEditingManagerCls},
-    {"ImageLoader", RCTImageLoaderCls},
-    {"ImageStoreManager", RCTImageStoreManagerCls},
-    {"LocalAssetImageLoader", RCTLocalAssetImageLoaderCls},
-  };
-
-  auto p = sCoreModuleClassMap->find(name);
-  if (p != sCoreModuleClassMap->end()) {
-    auto classFunc = p->second;
-    return classFunc();
+#import <string_view>
+
+using namespace std::literals;
+
+Class RCTImageClassProvider(const char *name)
+{
+
+  if (name == "BundleAssetImageLoader"sv) {
+    return RCTBundleAssetImageLoaderCls();
+  }
+
+  if (name == "GIFImageDecoder"sv) {
+    return RCTGIFImageDecoderCls();
+  }
+
+  if (name == "ImageEditingManager"sv) {
+    return RCTImageEditingManagerCls();
   }
+
+  if (name == "ImageLoader"sv) {
+    return RCTImageLoaderCls();
+  }
+
+  if (name == "ImageStoreManager"sv) {
+    return RCTImageStoreManagerCls();
+  }
+
+  if (name == "LocalAssetImageLoader"sv) {
+    return RCTLocalAssetImageLoaderCls();
+  }
+
   return nil;
 }
 

packages/react-native/Libraries/LinkingIOS/RCTLinkingPlugins.mm

@@ -13,20 +13,17 @@
 
 #import "RCTLinkingPlugins.h"
 
-#import <string>
-#import <unordered_map>
-
-Class RCTLinkingClassProvider(const char *name) {
-  // Intentionally leak to avoid crashing after static destructors are run.
-  static const auto sCoreModuleClassMap = new const std::unordered_map<std::string, Class (*)(void)>{
-    {"LinkingManager", RCTLinkingManagerCls},
-  };
-
-  auto p = sCoreModuleClassMap->find(name);
-  if (p != sCoreModuleClassMap->end()) {
-    auto classFunc = p->second;
-    return classFunc();
+#import <string_view>
+
+using namespace std::literals;
+
+Class RCTLinkingClassProvider(const char *name)
+{
+
+  if (name == "LinkingManager"sv) {
+    return RCTLinkingManagerCls();
   }
+
   return nil;
 }
 

packages/react-native/Libraries/NativeAnimation/RCTAnimationPlugins.mm

@@ -13,21 +13,21 @@
 
 #import "RCTAnimationPlugins.h"
 
-#import <string>
-#import <unordered_map>
-
-Class RCTAnimationClassProvider(const char *name) {
-  // Intentionally leak to avoid crashing after static destructors are run.
-  static const auto sCoreModuleClassMap = new const std::unordered_map<std::string, Class (*)(void)>{
-    {"NativeAnimatedModule", RCTNativeAnimatedModuleCls},
-    {"NativeAnimatedTurboModule", RCTNativeAnimatedTurboModuleCls},
-  };
-
-  auto p = sCoreModuleClassMap->find(name);
-  if (p != sCoreModuleClassMap->end()) {
-    auto classFunc = p->second;
-    return classFunc();
+#import <string_view>
+
+using namespace std::literals;
+
+Class RCTAnimationClassProvider(const char *name)
+{
+
+  if (name == "NativeAnimatedModule"sv) {
+    return RCTNativeAnimatedModuleCls();
   }
+
+  if (name == "NativeAnimatedTurboModule"sv) {
+    return RCTNativeAnimatedTurboModuleCls();
+  }
+
   return nil;
 }
 

packages/react-native/Libraries/Network/RCTNetworkPlugins.mm

@@ -13,23 +13,29 @@
 
 #import "RCTNetworkPlugins.h"
 
-#import <string>
-#import <unordered_map>
-
-Class RCTNetworkClassProvider(const char *name) {
-  // Intentionally leak to avoid crashing after static destructors are run.
-  static const auto sCoreModuleClassMap = new const std::unordered_map<std::string, Class (*)(void)>{
-    {"DataRequestHandler", RCTDataRequestHandlerCls},
-    {"FileRequestHandler", RCTFileRequestHandlerCls},
-    {"HTTPRequestHandler", RCTHTTPRequestHandlerCls},
-    {"Networking", RCTNetworkingCls},
-  };
-
-  auto p = sCoreModuleClassMap->find(name);
-  if (p != sCoreModuleClassMap->end()) {
-    auto classFunc = p->second;
-    return classFunc();
+#import <string_view>
+
+using namespace std::literals;
+
+Class RCTNetworkClassProvider(const char *name)
+{
+
+  if (name == "DataRequestHandler"sv) {
+    return RCTDataRequestHandlerCls();
+  }
+
+  if (name == "FileRequestHandler"sv) {
+    return RCTFileRequestHandlerCls();
   }
+
+  if (name == "HTTPRequestHandler"sv) {
+    return RCTHTTPRequestHandlerCls();
+  }
+
+  if (name == "Networking"sv) {
+    return RCTNetworkingCls();
+  }
+
   return nil;
 }
 

packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationPlugins.mm

@@ -13,20 +13,17 @@
 
 #import "RCTPushNotificationPlugins.h"
 
-#import <string>
-#import <unordered_map>
-
-Class RCTPushNotificationClassProvider(const char *name) {
-  // Intentionally leak to avoid crashing after static destructors are run.
-  static const auto sCoreModuleClassMap = new const std::unordered_map<std::string, Class (*)(void)>{
-    {"PushNotificationManager", RCTPushNotificationManagerCls},
-  };
-
-  auto p = sCoreModuleClassMap->find(name);
-  if (p != sCoreModuleClassMap->end()) {
-    auto classFunc = p->second;
-    return classFunc();
+#import <string_view>
+
+using namespace std::literals;
+
+Class RCTPushNotificationClassProvider(const char *name)
+{
+
+  if (name == "PushNotificationManager"sv) {
+    return RCTPushNotificationManagerCls();
   }
+
   return nil;
 }
 

packages/react-native/Libraries/Settings/RCTSettingsPlugins.mm

@@ -13,20 +13,17 @@
 
 #import "RCTSettingsPlugins.h"
 
-#import <string>
-#import <unordered_map>
-
-Class RCTSettingsClassProvider(const char *name) {
-  // Intentionally leak to avoid crashing after static destructors are run.
-  static const auto sCoreModuleClassMap = new const std::unordered_map<std::string, Class (*)(void)>{
-    {"SettingsManager", RCTSettingsManagerCls},
-  };
-
-  auto p = sCoreModuleClassMap->find(name);
-  if (p != sCoreModuleClassMap->end()) {
-    auto classFunc = p->second;
-    return classFunc();
+#import <string_view>
+
+using namespace std::literals;
+
+Class RCTSettingsClassProvider(const char *name)
+{
+
+  if (name == "SettingsManager"sv) {
+    return RCTSettingsManagerCls();
   }
+
   return nil;
 }
 

packages/react-native/Libraries/Vibration/RCTVibrationPlugins.mm

@@ -13,20 +13,17 @@
 
 #import "RCTVibrationPlugins.h"
 
-#import <string>
-#import <unordered_map>
-
-Class RCTVibrationClassProvider(const char *name) {
-  // Intentionally leak to avoid crashing after static destructors are run.
-  static const auto sCoreModuleClassMap = new const std::unordered_map<std::string, Class (*)(void)>{
-    {"Vibration", RCTVibrationCls},
-  };
-
-  auto p = sCoreModuleClassMap->find(name);
-  if (p != sCoreModuleClassMap->end()) {
-    auto classFunc = p->second;
-    return classFunc();
+#import <string_view>
+
+using namespace std::literals;
+
+Class RCTVibrationClassProvider(const char *name)
+{
+
+  if (name == "Vibration"sv) {
+    return RCTVibrationCls();
   }
+
   return nil;
 }