Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iOS): add colors to codegen output #46557

Closed
wants to merge 1 commit into from

Conversation

okwasniewski
Copy link
Contributor

Summary:

This PR is a quality-of-life improvement, adds colors to codegen output:

CleanShot 2024-09-18 at 12 18 00@2x

Makes it a lot easier to grasp what's going on in the actions taken by codegen.

Changelog:

[GENERAL] [ADDED] - Add color formatting to codegen output

Test Plan:

  1. Run codegen
  2. Expect colored output

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 18, 2024
@okwasniewski
Copy link
Contributor Author

Linter fails on API call for some reason

@okwasniewski okwasniewski changed the title feat: add colors to codegen output feat(iOS): add colors to codegen output Sep 18, 2024
@cipolleschi
Copy link
Contributor

The linter is saying that there are a bunch of things to change in one of the files you modified (specifically: generate-artifacts-executor.js). If you look the "Files" tab in this PR, you'll see the warnings.

@okwasniewski
Copy link
Contributor Author

Thanks, @cipolleschi linter is green now!

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 20, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 1747f57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants