Fix outline drawing 1px width when outlineWidth = 0 #46586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63136220 |
|
This pull request was exported from Phabricator. Differential Revision: D63136220 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Sep 20, 2024
Summary: Pull Request resolved: facebook#46586 When Paint.strokeWidth is set to 0 its not actually 0 but "hairline mode" so the fix is just to make outline not draw at all when outlineWidth = 0 {F1879399325} Changelog: [Internal] Differential Revision: D63136220
jorge-cab
force-pushed
the
export-D63136220
branch
from
0b8a716
to
f0cb2b1
Compare
Summary: Pull Request resolved: facebook#46586 When Paint.strokeWidth is set to 0 its not actually 0 but "hairline mode" so the fix is just to make outline not draw at all when outlineWidth = 0 {F1879399325} Changelog: [Internal] Reviewed By: joevilches Differential Revision: D63136220
|
This pull request was exported from Phabricator. Differential Revision: D63136220 |
jorge-cab
force-pushed
the
export-D63136220
branch
from
f0cb2b1
to
f70ee1a
Compare
|
This pull request has been merged in 8ad4b7d. |
|
This pull request was successfully merged by @jorge-cab in 8ad4b7d When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When Paint.strokeWidth is set to 0 its not actually 0 but "hairline mode" so the fix is just to make outline not draw at all when outlineWidth = 0 {F1879399325}
Changelog: [Internal]
Differential Revision: D63136220