Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of OTLP_TRACES_PROTOCOL is set to the endpoint #741

Closed
carlreid opened this issue Sep 20, 2024 · 3 comments
Closed

Value of OTLP_TRACES_PROTOCOL is set to the endpoint #741

carlreid opened this issue Sep 20, 2024 · 3 comments
Assignees
Labels

Comments

@carlreid
Copy link

Describe the bug

Although the README describes the following:

config.otlp.traces.protocol | string | "" | OTLP protocol http/json, http/protobuf, grpc (default: "" which uses SDK default: http/json) |

The value of the OTLP_TRACES_PROTOCOL is being set to the same value as .Values.config.otlp.traces.endpoint.

How to reproduce it

Try set config as;

  falcosidekick:
    enabled: true
    fullfqdn: true
    webui:
      enabled: true
      disableauth: true
      replicaCount: 1
    config:
      otlp:
        traces:
          endpoint: "http://my-collector-endpoint:4318/v1/traces"
          protocol: "http/json"
          checkcert: false

Then observe protocol is not passed.

Expected behaviour

That the OTLP_TRACES_PROTOCOL is being set to the config.otlp.traces.protocol value.

@Issif
Copy link
Member

Issif commented Sep 20, 2024

You're write, this is typo. The fix is now included in the PR #740

@carlreid
Copy link
Author

carlreid commented Sep 20, 2024

I did open a PR for this too though already: #742

Of course do it whichever way 👍

Edit: Ah I see your comment over there.

@Issif
Copy link
Member

Issif commented Oct 4, 2024

The PR #740 has been merged with the fix

@Issif Issif closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants