-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: new(cmd,pkg): leverage falcoctl to skip generating configs for kernels where modern bpf is supported #43
Conversation
…s where modern bpf is supported. This behavior is disabled by default at the moment. Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is not a label identifying the kind of this PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Wip because this requires falcosecurity/falcoctl#484. |
github.com/aws/aws-sdk-go-v2/config v1.27.4 | ||
github.com/aws/aws-sdk-go-v2/credentials v1.17.4 | ||
github.com/aws/aws-sdk-go-v2/service/s3 v1.40.0 | ||
github.com/falcosecurity/driverkit v0.16.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to bump driverkit to v0.17.x on falcoctl too, before merging this!
/close |
@FedeDP: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area cmd
/area pkg
What this PR does / why we need it:
Given our new roadmap: https://falco.org/docs/roadmap/, and the fact that for Falco 1.0.0 we are targeting to default to the modern bpf probe, i added an option to dbg-go to avoid generating configs for kernel where modern bpf is supported, disabling building of drivers for those kernels.
This behavior is disabled by default at the moment.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: