Skip to content

sigir_2022_BISER Code Review #29

@Hamedloghmani

Description

@Hamedloghmani

This issue is just a log file of my progress in reviewing the sigir_2022_BISER repo.

After running the given examples for the first time. My initial thoughts is that the code is not really user friendly and understandable on first attempts. Lacks a lot of comments and even some of the comments are in Korean I guess. There were some points that was kind of surprising since this repo is the official codebase for SIGIR 2022 accepted paper.

  1. Inconsistency in the material for creating an environment.

  2. Using Tensorflow 1.* in a code developed in 2021-22.

  3. Lack of proper comments and explanation in this code.

  4. Some small issues like importing a library and not using it.

A snap shot of the first run:
BISER first run

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions