Remove option, only accept via ENV var

Author: YuriiMotov

src/fastapi_cli/cli.py

@@ -1,4 +1,5 @@
 import logging
+import os
 from pathlib import Path
 from typing import Annotated, Any
 
@@ -300,13 +301,6 @@ def dev(
             help="Comma separated list of IP Addresses to trust with proxy headers. The literal '*' means trust everything."
         ),
     ] = None,
-    public_url: Annotated[
-        str | None,
-        typer.Option(
-            help="The public URL where the server is accessible. Used for the URLs printed at startup. Defaults to [blue]http://HOST:PORT[/blue] from [bold]--host[/bold] and [bold]--port[/bold].",
-            envvar="FASTAPI_PUBLIC_URL",
-        ),
-    ] = None,
 ) -> Any:
     """
     Run a [bold]FastAPI[/bold] app in [yellow]development[/yellow] mode. 🧪
@@ -345,7 +339,7 @@ def dev(
         command="dev",
         proxy_headers=proxy_headers,
         forwarded_allow_ips=forwarded_allow_ips,
-        public_url=public_url,
+        public_url=os.getenv("FASTAPI_PUBLIC_URL"),
     )
 
 
@@ -415,13 +409,6 @@ def run(
             help="Comma separated list of IP Addresses to trust with proxy headers. The literal '*' means trust everything."
         ),
     ] = None,
-    public_url: Annotated[
-        str | None,
-        typer.Option(
-            help="The public URL where the server is accessible. Used for the URLs printed at startup. By default, the printed URLs use the configured host and port.",
-            envvar="FASTAPI_PUBLIC_URL",
-        ),
-    ] = None,
 ) -> Any:
     """
     Run a [bold]FastAPI[/bold] app in [green]production[/green] mode. 🚀
@@ -460,7 +447,7 @@ def run(
         command="run",
         proxy_headers=proxy_headers,
         forwarded_allow_ips=forwarded_allow_ips,
-        public_url=public_url,
+        public_url=os.getenv("FASTAPI_PUBLIC_URL"),
     )
 
 

tests/test_cli.py

@@ -392,55 +392,6 @@ def test_run_env_vars_and_args() -> None:
         assert "Documentation at http://0.0.0.0:8080/docs" in result.output
 
 
-@pytest.mark.parametrize("command", ["dev", "run"])
-@pytest.mark.parametrize(
-    "public_url",
-    [
-        "https://myapp.example.com",
-        "https://myapp.example.com/",
-        "https://myapp.example.com/subpath/",
-    ],
-)
-def test_public_url(command: str, public_url: str) -> None:
-    with changing_dir(assets_path):
-        with patch.object(uvicorn, "run") as mock_run:
-            result = runner.invoke(
-                app,
-                [
-                    command,
-                    "single_file_app.py",
-                    "--host",
-                    "0.0.0.0",
-                    "--public-url",
-                    public_url,
-                ],
-            )
-            assert result.exit_code == 0, result.output
-            assert mock_run.called
-            assert mock_run.call_args
-            assert mock_run.call_args.kwargs == {
-                "app": "single_file_app:app",
-                "host": "0.0.0.0",
-                "port": 8000,
-                "reload": True if command == "dev" else False,
-                "reload_dirs": None,
-                "workers": None,
-                "root_path": "",
-                "proxy_headers": True,
-                "forwarded_allow_ips": None,
-                "log_config": get_uvicorn_log_config(),
-            }
-
-        assert "Using import string: single_file_app:app" in result.output
-        assert (
-            f"Starting {'development' if command == 'dev' else 'production'} server 🚀"
-            in result.output
-        )
-        expected_url_base = public_url.rstrip("/")
-        assert f"Server started at {expected_url_base}" in result.output
-        assert f"Documentation at {expected_url_base}/docs" in result.output
-
-
 @pytest.mark.parametrize("command", ["dev", "run"])
 @pytest.mark.parametrize(
     "public_url",
@@ -515,7 +466,6 @@ def test_dev_help() -> None:
     assert "Set reload directories explicitly" in result.output
     assert "The root path is used to tell your app" in result.output
     assert "The name of the variable that contains the FastAPI app" in result.output
-    assert "The public URL where the server is accessible" in result.output
     assert "Use multiple worker processes." not in result.output
 
 
@@ -537,7 +487,6 @@ def test_run_help() -> None:
     assert "Enable auto-reload of the server when (code) files change." in result.output
     assert "The root path is used to tell your app" in result.output
     assert "The name of the variable that contains the FastAPI app" in result.output
-    assert "The public URL where the server is accessible" in result.output
     assert "Use multiple worker processes." in result.output