Result not re-exported from typer.testing for static type checkers

[Fatiz]

First Check

• I added a very descriptive title here.
• I used the GitHub search to find a similar question and didn't find it.
• I searched the documentation, with the integrated search.
• I already searched in Google "How to X" and didn't find any information.
• I already read and followed all the tutorials in the docs and didn't find an answer.

Example Code

from typer.testing import CliRunner, Result

runner = CliRunner()

def run(*args: str) -> Result:
    return runner.invoke(cli(), args)

# Results in
# "Result" is not exported from module "typer.testing"
#   Import from "typer._click.testing" instead (reportPrivateImportUsage)

Description

Since Typer vendored Click internally, the Result type from typer.testing is no longer considered publicly exported by static type checkers (pyright, pylance).

Previously, users could import Result from click.testing directly, but now that Click lives under typer._click, this is no longer possible without importing from a private module

Operating System

Linux

Operating System Details

No response

Project Version

0.26.1

Python Version

3.12.3

Additional Context

Following https://tiangolo.com/open-source/contributing/#start-with-a-discussion I didn't wanna open a PR directly 😅

[svlandeg]

Thanks! We'll look into this ASAP 🙏

[svlandeg]

Ok, so I had a quick look.

Since Typer vendored Click internally, the Result type from typer.testing is no longer considered publicly exported by static type checkers (pyright, pylance).

This is actually kind of by design: we've moved all the Click internals to a _click module to signal that these shouldn't be used directly.

I can see the argument for needing to access Result directly though. One of the things I wanted to do in follow-up work is to merge the code from typer.testing and ._click.testing, also merge the CliRunner classes, and move it all directly into Typer. I'll quickly verify with @tiangolo if he agrees, and will then work on it.

[Fatiz]

That makes sense and sounds good to me. Thanks, @svlandeg appreciate it!

[svlandeg]

PR: #1792. That should fix it for you, right @Fatiz ? You'd be able to import Result from typer.testing?

[Fatiz]

Yep, just tested and all is good! Thank you :D