Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 25, 2025

Summary

This PR wires up the deeplink2 plugin to handle deep link URLs in the desktop app. When a deep link URL (e.g., hypr://notification?key=xyz) is received by the OS, the plugin now parses it and emits a DeepLinkEvent that the frontend listens for and navigates accordingly.

Changes:

  • Added tauri-plugin-deep-link dependency to hook into OS-level deep link events
  • Modified plugins/deeplink2/src/lib.rs to listen for deep link URLs via on_open_url and emit DeepLinkEvent
  • Updated apps/desktop/src/routes/__root.tsx to listen for DeepLinkEvent and navigate to the appropriate route
  • Updated /notification route to validate the key search param from NotificationSearch

Review & Testing Checklist for Human

  • Verify notification route behavior: The notification route currently logs the search params and redirects to /app/main. Confirm this is the intended behavior or if additional handling is needed for the key param.
  • Test deep link end-to-end: Build the desktop app and test that clicking a hypr://notification?key=test link opens the app and triggers the navigation. This requires OS-level deep link registration.
  • Verify deep link URL format: The parser expects URLs like hypr://notification?key=xyz. Confirm this matches the format used when creating notifications with URLs.

Test Plan

  1. Build the desktop app
  2. Register the hypr:// scheme with the OS (should happen automatically via Tauri config)
  3. Create a notification with a URL like hypr://notification?key=test123
  4. Click the notification and verify the app opens and navigates correctly
  5. Check console logs for "notification deeplink received" with the correct search params

Local Testing

  • Desktop app builds and runs successfully (ONBOARDING=0 pnpm -F desktop tauri dev)
  • All CI checks pass (fmt, linux CI, macOS CI)

Local testing - app running

Notes

- Add tauri-plugin-deep-link dependency to deeplink2 plugin
- Hook into tauri_plugin_deep_link to listen for deep link URLs
- Parse deep link URLs and emit DeepLinkEvent
- Wire up frontend to listen for DeepLinkEvent and navigate
- Update notification route to handle key search param

Co-Authored-By: yujonglee <[email protected]>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 1177c2d
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/6925a48f4d05b500086eb756
😎 Deploy Preview https://deploy-preview-1886--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit 1177c2d
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/6925a48f2ca14d0008a247e8
😎 Deploy Preview https://deploy-preview-1886--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1764073930-deeplink2-integration

Comment @coderabbitai help to get the list of available commands and usage tips.

@yujonglee yujonglee merged commit d50b60e into main Nov 26, 2025
13 checks passed
@yujonglee yujonglee deleted the devin/1764073930-deeplink2-integration branch November 26, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants