-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
there is an issue resulting of the environment configuration I guess.
This plugin has the following function that return the logo from an organization
openedx-corporate/partner_catalog/api/v1/serializers.py
Lines 95 to 102 in 73a3694
| def get_logo(self, obj): | |
| """Return the URL of the corporate partner organization's logo.""" | |
| try: | |
| if obj.organization and obj.organization.logo: | |
| return f"{settings.LMS_ROOT_URL}{obj.organization.logo.url}" | |
| except (ValueError, AttributeError): | |
| pass | |
| return None |
The function append the LMS_ROOT_URL what is okay to resolve the URL in local environment but cause a double domain in production (stage instance) where the url is associated to a S3 bucket.
I think the solution is just return
return obj.organization.logo.urlhowever, that will cause the error in development because the returning is a relative path, that can not resolve.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels