client-java-android failed to get features

[Mystery00]

Per the aforementioned pull request, the edge server is expected to respond with a 304 status when there are no changes in the feature and the data has been previously retrieved. However, the client-java-android does not handle response codes beyond 200-300, 400, and 404. This deficiency may result in the logic within ClientContext.build() being perpetually stalled at the stage where a CompletableFuture is instantiated but not completed. Subsequently, invoking the get() method on this particular CompletableFuture will lead to a persistent blockage of the logic flow without any resolution.

[rvowles]

I would have expected isSuccessful would return true on a 304, thats curious.

[Mystery00]

Upon receiving a 304 response with an empty body, I delved into debugging this issue within a project. Employing the direct execution logic of 'isSuccessful' triggered errors due to the absence of 'features' data. Consequently, I replicated the contents of this class, specifically tailoring a unique handling framework for the 304 scenario, directing it solely towards the execution of reporting results and updating polling intervals.

Furthermore, I infer that adequate provisions for handling 5xx errors and cases of request failures should be in place. In a genuine network environment, instances of request failures or server-side malfunctions leading to 5xx responses are quite commonplace.

Link for reference: MyFeatureHubClient.kt

[rvowles]

Yes, you are right, the new version handles 5xx errors, but the completeReadiness() is never called for a 304.