From e3a59a8bd79308c2c3e57b49b04406717db8236f Mon Sep 17 00:00:00 2001 From: Victor Nogueira Date: Tue, 4 Aug 2026 23:08:01 -0300 Subject: [PATCH 1/3] chore: add Hadolint to CI lint pipeline Add Dockerfile validation to the CI pipeline using Hadolint. Suppress rules that are not applicable to our Dockerfile: - DL3064: ARG with commit SHA is not sensitive data - DL3008: Pinning apt package versions is impractical - SC2046: Intentional shell expansion for random key generation - DL3025: CMD uses shell form to run multiple background processes Fixes #2285 --- .github/workflows/ci.yml | 3 +++ .hadolint.yaml | 8 ++++++++ 2 files changed, 11 insertions(+) create mode 100644 .hadolint.yaml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 21da237a3..0d8e28a36 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,6 +32,9 @@ jobs: - name: Run lint run: npm run lint + - name: Lint Dockerfile + run: hadolint Dockerfile + - name: Check formatting run: npm run format:check diff --git a/.hadolint.yaml b/.hadolint.yaml new file mode 100644 index 000000000..53eb9a72b --- /dev/null +++ b/.hadolint.yaml @@ -0,0 +1,8 @@ +# Hadolint configuration for MiniSearch +# Suppress rules that are not applicable to our Dockerfile + +ignored: + - DL3064 + - DL3008 + - SC2046 + - DL3025 From 53d27bc2b817806b393aecba6eb60d68c2721a12 Mon Sep 17 00:00:00 2001 From: Victor Nogueira Date: Tue, 4 Aug 2026 23:11:51 -0300 Subject: [PATCH 2/3] chore: install hadolint in CI before linting --- .github/workflows/ci.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0d8e28a36..a3785cb48 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,6 +32,12 @@ jobs: - name: Run lint run: npm run lint + - name: Install hadolint + uses: hadolint/hadolint-action@v3.1.0 + with: + dockerfile: Dockerfile + version: latest + - name: Lint Dockerfile run: hadolint Dockerfile From aecc6c20edef6b60e973784a338d499f741b8e92 Mon Sep 17 00:00:00 2001 From: Victor Nogueira Date: Tue, 4 Aug 2026 23:31:54 -0300 Subject: [PATCH 3/3] chore: fix hadolint CI step to use action directly --- .github/workflows/ci.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a3785cb48..ddd330dd6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,14 +32,10 @@ jobs: - name: Run lint run: npm run lint - - name: Install hadolint + - name: Lint Dockerfile uses: hadolint/hadolint-action@v3.1.0 with: dockerfile: Dockerfile - version: latest - - - name: Lint Dockerfile - run: hadolint Dockerfile - name: Check formatting run: npm run format:check