-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version constraint for Composer 1 does not allow ACF 5.10.x to update #43
Comments
Please issue {
"name": "private-composer-installer/issue-43",
"description": "https://github.com/ffraenz/private-composer-installer/issues/43",
"license": "proprietary",
"require": {
"advanced-custom-fields/advanced-custom-fields-pro": "^5.10"
},
"repositories": [
{
"type": "package",
"package": {
"name": "advanced-custom-fields/advanced-custom-fields-pro",
"version": "5.10.1",
"type": "wordpress-plugin",
"dist": {
"type": "zip",
"url": "https://connect.advancedcustomfields.com/index.php?a=download&p=pro&k={%PLUGIN_ACF_KEY}&t={%VERSION}"
},
"require": {
"composer/installers": "^1.4",
"ffraenz/private-composer-installer": "^5.0"
}
}
}
]
} It works with Composer v1 (latest) on PHP 7.4. |
I'm not sure where the error message would originate from. I'm not aware of any version validation logic in this plugin similar to this function. As arbitrary packages may be used, any version gets accepted. |
Thanks for the responses. I'll revisit the package updates and make sure I converted from philippbaschke properly. ... Composer 1 updates worked, my error! Powershell error stated something like philippbaschke was still being referenced in cache, so I hadn't fully removed it from my system. |
This issue here:
PhilippBaschke/acf-pro-installer#47
also exists for ffraenz/private-composer-installer when using Composer 1. I got the same error message:
Updating to Composer 2 does not have this issue.
If using Composer 1, this solution works for philippbaschke, but since ffraenz's isn't acf-pro exclusive, the same solution doesn't look like it applies.
PhilippBaschke/acf-pro-installer@13ec41e
The text was updated successfully, but these errors were encountered: