-
Notifications
You must be signed in to change notification settings - Fork 86
ci: upload release again before the release is published #1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Per slack, this proposed workflow has been approved. Thanks! Also, can you please update https://github.com/filecoin-project/builtin-actors/blob/master/RELEASE.md#current-state as well? Thanks! |
- name: Setting up cache | ||
uses: pl-strflt/rust-sccache-action@v1 | ||
env: | ||
SCCACHE_CACHE_SIZE: 2G | ||
SCCACHE_DIR: ${{ github.workspace }}/.cache/sccache | ||
CACHE_SKIP_SAVE: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now build in a docker container so this isn't going to do much (unless it caches docker layers).
Releases are now built on merge. And, from what I can tell, they _should_ be built even if/when we bypass the merge process.
I've taken a stab at updating the docs from my understanding of these changes, but I'm not 100% sure I got it correct. Especially with respect to what happens if we push directly to master. From what I can tell, pushing a release to master should also cut the release now? |
That's right! Thank you for updating the docs 🙇 It all looks correct. I think we're ready to proceed with this. |
Thanks! |
Resolves #1656
In this PR I extracted the release upload action to a separate workflow that can be triggered either manually or from other workflows. After this PR is merged, the release flow will be as follows:
Release assets are uploaded to the draft release.If this sounds reasonable to you, I'm going to proceed with the tests of this flow in a fork of this repository.