Skip to content

ci: upload release again before the release is published #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 18, 2025

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Mar 15, 2025

Resolves #1656

In this PR I extracted the release upload action to a separate workflow that can be triggered either manually or from other workflows. After this PR is merged, the release flow will be as follows:

  1. I create a release PR.
  2. CI creates a draft release.
  3. Release assets are uploaded to the draft release.
  4. I merge the release PR.
  5. CI ensures the draft release exists.
  6. CI uploads release assets to the draft release.
  7. CI publishes the draft release.

If this sounds reasonable to you, I'm going to proceed with the tests of this flow in a fork of this repository.

@galargh galargh requested a review from Stebalien March 15, 2025 10:46
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Mar 15, 2025
@BigLep
Copy link
Member

BigLep commented Mar 17, 2025

Per slack, this proposed workflow has been approved. Thanks!

Also, can you please update https://github.com/filecoin-project/builtin-actors/blob/master/RELEASE.md#current-state as well? Thanks!

Comment on lines 46 to 51
- name: Setting up cache
uses: pl-strflt/rust-sccache-action@v1
env:
SCCACHE_CACHE_SIZE: 2G
SCCACHE_DIR: ${{ github.workspace }}/.cache/sccache
CACHE_SKIP_SAVE: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now build in a docker container so this isn't going to do much (unless it caches docker layers).

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Mar 17, 2025
Releases are now built on merge. And, from what I can tell, they
_should_ be built even if/when we bypass the merge process.
@Stebalien
Copy link
Member

I've taken a stab at updating the docs from my understanding of these changes, but I'm not 100% sure I got it correct. Especially with respect to what happens if we push directly to master. From what I can tell, pushing a release to master should also cut the release now?

@galargh
Copy link
Contributor Author

galargh commented Mar 18, 2025

From what I can tell, pushing a release to master should also cut the release now?

That's right! Thank you for updating the docs 🙇 It all looks correct. I think we're ready to proceed with this.

@galargh galargh marked this pull request as ready for review March 18, 2025 18:29
@Stebalien Stebalien added this pull request to the merge queue Mar 18, 2025
@Stebalien
Copy link
Member

Thanks!

Merged via the queue into master with commit d922800 Mar 18, 2025
15 checks passed
@Stebalien Stebalien deleted the release-assets branch March 18, 2025 19:36
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

Build correct branch in release automation
3 participants