Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplicated code in miner tests #479

Open
LesnyRumcajs opened this issue Jun 15, 2022 · 0 comments
Open

Reduce duplicated code in miner tests #479

LesnyRumcajs opened this issue Jun 15, 2022 · 0 comments
Labels
cleanup enhancement New feature or request good first issue Good for newcomers P3 testing
Milestone

Comments

@LesnyRumcajs
Copy link
Contributor

Miner tests effort was done by several devs in parallel, sometimes resulting in duplicated code / re-defined constants etc. For example, there are 13 occurrences of const BIG_BALANCE: u128 = 1_000_000_000_000_000_000_000_000u128;. It would be nice to go through those different files and extract common constants and helper methods.

It may be worth checking out other actors as well. On a higher level, it may be worth extracting some code to test_utils if multiple actor tests need a similar piece of technology, e.g. bitfield creation/manipulation.

@jennijuju jennijuju added P3 enhancement New feature or request area/test good first issue Good for newcomers labels Aug 11, 2022
@jennijuju jennijuju added this to the Network v17 milestone Aug 11, 2022
@anorth anorth moved this to Todo in Network nv17 Aug 11, 2022
@anorth anorth moved this from Todo to Opportunistic in Network nv17 Aug 11, 2022
@jennijuju jennijuju removed this from Network nv17 Nov 25, 2022
@anorth anorth added testing and removed area/test labels Mar 30, 2023
@anorth anorth added the cleanup label May 27, 2024
@anorth anorth added this to FilOz May 28, 2024
@rjan90 rjan90 moved this to 📌 Triage in FilOz Jun 4, 2024
@rjan90 rjan90 removed the status in FilOz Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement New feature or request good first issue Good for newcomers P3 testing
Projects
Status: No status
Development

No branches or pull requests

4 participants