Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Remove duplicate testing frameworks #958

Open
Stebalien opened this issue Dec 15, 2022 · 1 comment
Open

EVM: Remove duplicate testing frameworks #958

Stebalien opened this issue Dec 15, 2022 · 1 comment
Labels
cleanup enhancement New feature or request testing

Comments

@Stebalien
Copy link
Member

We have:

  • Functions in evm/tests/utils.rs for constructing actors.
  • A framework in evm/tests/env.rs that duplicates the same logic.

We should probably just switch to a framework as that'll make it easier to manage. But we also have to consider which approach will be easier.

@Stebalien Stebalien added enhancement New feature or request area/test labels Dec 15, 2022
@Stebalien
Copy link
Member Author

Specifically, both of these files provide tools for:

  • Deploying EVM smart contracts (init_construct_and_verify, TestEnv::deploy).
  • Calling EVM smart contracts (invoke_contract, TestEnv::call).

We should standardize around one abstraction (likely the TestEnv one unless switching to it is too disruptive).

@anorth anorth added enhancement New feature or request cleanup and removed enhancement New feature or request labels Mar 3, 2023
@anorth anorth added testing and removed area/test labels Mar 30, 2023
@rjan90 rjan90 added this to FilOz Sep 17, 2024
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 17, 2024
@rjan90 rjan90 removed the status in FilOz Sep 17, 2024
@rjan90 rjan90 moved this to 🐱 Todo in FilOz Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement New feature or request testing
Projects
Status: 🐱 Todo
Development

No branches or pull requests

2 participants