Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit all uses of flags option passed to fs functions, match node #671

Closed
humphd opened this issue Jan 25, 2019 · 2 comments
Closed

Audit all uses of flags option passed to fs functions, match node #671

humphd opened this issue Jan 25, 2019 · 2 comments

Comments

@humphd
Copy link
Contributor

humphd commented Jan 25, 2019

The way we're doing flags in our fs methods is wrong. We should be expecting a String, and it should be one of the expected flag values. We seem to assume it will be an Object, see writeFile for an example of this.

Let's overhaul how we do flags, and match what node does.
@humphd
Copy link
Contributor Author

humphd commented Jan 25, 2019

I'm wrong, it does check it as a string, but I still think it needs an audit.

@humphd
Copy link
Contributor Author

humphd commented Mar 7, 2019

Dupe of #747.

@humphd humphd closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@humphd