Replace with CsWin32 in AccessControlPrincipal

Author: 0x5bfa

src/Files.App/Data/Items/AccessControlPrincipal.cs

@@ -1,9 +1,9 @@
 // Copyright (c) 2024 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
-using System.Text;
-using Vanara.PInvoke;
-using static Vanara.PInvoke.AdvApi32;
+using Windows.Win32;
+using Windows.Win32.Foundation;
+using Windows.Win32.Security;
 
 namespace Files.App.Data.Items
 {
@@ -66,26 +66,37 @@ public string? FullNameHumanized
 		public string FullNameHumanizedWithBrackes
 			=> string.IsNullOrEmpty(Domain) ? string.Empty : $"({Domain}\\{Name})";
 
-		public AccessControlPrincipal(string sid)
+		public unsafe AccessControlPrincipal(string sid)
 		{
 			if (string.IsNullOrEmpty(sid))
 				return;
 
 			Sid = sid;
-			var lpSid = ConvertStringSidToSid(sid);
+			PSID lpSid = default;
+			SID_NAME_USE snu = default;
 
-			StringBuilder lpName = new(), lpDomain = new();
-			int cchName = 0, cchDomainName = 0;
+			fixed (char* cSid = sid)
+			{
+				// Get PSID object from string sid
+				PInvoke.ConvertStringSidToSid(new PCWSTR(cSid), &lpSid);
+			}
+
+			PWSTR lpName = default;
+			PWSTR lpDomain = default;
+			uint cchName = 0, cchDomainName = 0;
 
 			// Get size of account name and domain name
-			bool bResult = LookupAccountSid(null, lpSid, lpName, ref cchName, lpDomain, ref cchDomainName, out _);
+			bool bResult = PInvoke.LookupAccountSid(new PCWSTR(), lpSid, lpName, &cchName, lpDomain, &cchDomainName, null);
 
 			// Ensure requested capacity
-			lpName.EnsureCapacity(cchName);
-			lpDomain.EnsureCapacity(cchDomainName);
+			fixed (char* cName = new char[cchName])
+				lpName = new(cName);
+
+			fixed (char* cDomain = new char[cchDomainName])
+				lpDomain = new(cDomain);
 
 			// Get account name and domain
-			bResult = LookupAccountSid(null, lpSid, lpName, ref cchName, lpDomain, ref cchDomainName, out var snu);
+			bResult = PInvoke.LookupAccountSid(new PCWSTR(), lpSid, lpName, &cchName, lpDomain, &cchDomainName, &snu);
 			if(!bResult)
 				return;
 
@@ -106,14 +117,14 @@ var x when
 				_ => AccessControlPrincipalType.Unknown
 			};
 
-			lpDomain.Clear();
-
 			// Replace domain name with computer name if the account type is user or alias type
 			if (snu == SID_NAME_USE.SidTypeUser || snu == SID_NAME_USE.SidTypeAlias)
 			{
-				lpDomain = new(256, 256);
-				uint size = (uint)lpDomain.Capacity;
-				bResult = Kernel32.GetComputerName(lpDomain, ref size);
+				uint size = 256;
+				fixed (char* cDomain = new char[size])
+					lpDomain = new(cDomain);
+
+				bResult = PInvoke.GetComputerName(lpDomain, ref size);
 				if (!bResult)
 					return;
 			}

src/Files.App/NativeMethods.txt

@@ -82,4 +82,5 @@ ACL_SIZE_INFORMATION
 DeleteAce
 EXPLICIT_ACCESS
 ACCESS_ALLOWED_ACE
-ACCESS_MASK
+LookupAccountSid
+GetComputerName

src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs

@@ -187,7 +187,7 @@ private void LoadAccessControlEntry()
 					ErrorMessage =
 						"SecurityUnableToDisplayPermissions".GetLocalizedResource() +
 						"\r\n\r\n" +
-						error.FormatMessage();
+						error.ToString();
 				}
 			}
 			else