Skip to content

Commit 2981818

Browse files
authored
Merge pull request #154 from finpik/feature/FP-32
[FP-32] 에러코드 오타 수정
2 parents e842d1f + e79c974 commit 2981818

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

finpik-api/src/main/java/finpik/resolver/loanproduct/application/impl/CreateRecommendLoanProductUseCaseImpl.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ public class CreateRecommendLoanProductUseCaseImpl implements
3434
@EventListener
3535
@Transactional(propagation = Propagation.REQUIRES_NEW)
3636
public void execute(CreateRecommendedLoanProductEvent event) {
37-
//TODO 혹여 해당 부분이 실패할 경우 어떻게 해야할지 강구
38-
3937
List<RecommendedLoanProduct> recommendedLoanProductList = event.contentList().stream()
4038
.map(content ->
4139
RecommendedLoanProduct.of(
@@ -53,10 +51,14 @@ public void execute(CreateRecommendedLoanProductEvent event) {
5351
List<RecommendedLoanProduct> recommendedLoanProducts =
5452
loanProductRepository.saveAllRecommendedLoanProduct(event.profileId(), recommendedLoanProductList);
5553

54+
log.info("Created {} recommended loan product events", recommendedLoanProducts.stream().filter(it ->
55+
it.getLoanProductBadges().contains(LoanProductBadge.LOWEST_MIN_INTEREST_RATE)
56+
).toList().size());
57+
5658
RecommendedLoanProduct first = recommendedLoanProducts.stream()
5759
.filter(it ->
5860
it.getLoanProductBadges().contains(LoanProductBadge.LOWEST_MIN_INTEREST_RATE)
59-
).findFirst().orElseThrow(() -> new BusinessException(ErrorCode.INVALID_ANNUAL_INCOME));
61+
).findFirst().orElseThrow(() -> new BusinessException(ErrorCode.EMPTY_BADGES));
6062

6163
profileRepository.updateProfileAfterRecommend(
6264
event.profileId(), recommendedLoanProductList.size(), first.getMinInterestRate()

finpik-common/src/main/java/finpik/error/enums/ErrorCode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public enum ErrorCode {
4040
PROFILE_SEQUENCE_CANNOT_BE_NULL("프로필의 순번이 NULL일 수 없습니다.", "PRF-0008", CustomHttpStatus.BAD_REQUEST),
4141
CREDITS_CANNOT_BE_NULL("프로필의 신용점수, 신용상태 둘다 NULL일 수 없습니다.", "PRF-0009", CustomHttpStatus.BAD_REQUEST),
4242
OUT_OF_RANGE_CREDIT_GRADE_STATUS("신용점수에 맞는 신용 등급이 존재하지 않습니다.", "PRF-0010", CustomHttpStatus.BAD_REQUEST),
43-
INVALID_ANNUAL_INCOME("유효하지 않은 연수입 입니다. 값을 확인해주세요.", "PRF-0011", CustomHttpStatus.BAD_REQUEST),
43+
INVALID_ANNUAL_INCOME("유효하지 않은 연수입니다. 값을 확인해주세요.", "PRF-0011", CustomHttpStatus.BAD_REQUEST),
4444
INVALID_PUBLIC_SERVANT_FIELDS("공무워 직군 관련 필드에 문제가 있습니다.", "PRF-0012", CustomHttpStatus.BAD_REQUEST),
4545
INVALID_FREELANCER_FIELDS("프리랜서 직군 관련 필드에 문제가 있습니다.", "PRF-0013", CustomHttpStatus.BAD_REQUEST),
4646
UNSUPPORTED_OCCUPATION("지원하지 않는 직군입니다.", "PRF-0014", CustomHttpStatus.BAD_REQUEST),

0 commit comments

Comments
 (0)