refactor(crashlytics): remove CI check from error reporting in Android and iOS implementations

Author: SelaseKay

packages/firebase_crashlytics/firebase_crashlytics/android/src/main/java/io/flutter/plugins/firebase/crashlytics/FlutterFirebaseCrashlyticsPlugin.java

@@ -71,12 +71,6 @@ public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) {
     }
   }
 
-  private boolean isRunningInCI() {
-    Map<String, String> env = System.getenv();
-    //    return env.containsKey("GITHUB_ACTIONS");
-    return true;
-  }
-
   private Task<Map<String, Object>> checkForUnsentReports() {
     TaskCompletionSource<Map<String, Object>> taskCompletionSource = new TaskCompletionSource<>();
 
@@ -178,9 +172,7 @@ private Task<Void> recordError(final Map<String, Object> arguments) {
             Exception exception;
             if (reason != null) {
               final String crashlyticsErrorReason = "thrown " + reason;
-              if (isRunningInCI() && testEventSink != null) {
-                mainHandler.post(() -> testEventSink.success(crashlyticsErrorReason));
-              }
+              mainHandler.post(() -> testEventSink.success(crashlyticsErrorReason));
               // Set a "reason" (to match iOS) to show where the exception was thrown.
               crashlytics.setCustomKey(Constants.FLUTTER_ERROR_REASON, crashlyticsErrorReason);
               exception =

packages/firebase_crashlytics/firebase_crashlytics/ios/firebase_crashlytics/Sources/firebase_crashlytics/FLTFirebaseCrashlyticsPlugin.m

@@ -74,11 +74,6 @@ + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
   [instance.testEventChannel setStreamHandler:instance];
 }
 
-- (BOOL)isRunningInCI {
-  NSDictionary *env = [[NSProcessInfo processInfo] environment];
-  return env[@"GITHUB_ACTIONS"] != nil;
-}
-
 - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)flutterResult {
   FLTFirebaseMethodCallErrorBlock errorBlock =
       ^(NSString *_Nullable code, NSString *_Nullable message, NSDictionary *_Nullable details,
@@ -143,9 +138,8 @@ - (void)recordError:(id)arguments withMethodCallResult:(FLTFirebaseMethodCallRes
 
   if (![reason isEqual:[NSNull null]]) {
     NSString *crashlyticsErrorReason = [NSString stringWithFormat:@"thrown %@", reason];
-    // if ([self isRunningInCI] && self.testEventSink) {
+
     self.testEventSink(crashlyticsErrorReason);
-    // }
     // Log additional custom value to match Android.
     [[FIRCrashlytics crashlytics] setCustomValue:[NSString stringWithFormat:@"thrown %@", reason]
                                           forKey:@"flutter_error_reason"];