Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This repository seems out of sync with the CodeLab documentation. #257

Open
takaodaze opened this issue Oct 18, 2023 · 1 comment
Open

Comments

@takaodaze
Copy link

https://firebase.google.com/codelabs/firestore-web?hl=ja#5

I was following this tutorial and felt uncomfortable as I was learning.
Apparently, this tutorial instructs you to run firebase use --add or firebase emulators:start --only hosting in the top-level directory of the repository, but this command is not actually valid.

After trying various things, it seems that this tutorial assumes that the commands are to be run in the vanilla-js directory.

Perhaps the tutorial documentation and the repository are out of sync.

I would like to suggest an improvement.

@IWATA-san
Copy link

vanilla-jsディテクトリ内にあるindex.htmlではなく、public/index.htmlを参照してしまいます。
以下を試しても直せませんでした。

  • firebase.json のhosting:public を変更
  • vanilla-js/index.htmlをpublicディテクトリ内に移動

修正方法を教えて欲しいです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants