[BUG] in sample: linkedin-auth: depends on "node-linkedin" library which has been broken for 2 years

[jkff]

Which sample has a bug?

linkedin-auth

How to reproduce the issue

Trying to follow the sample as-is hits a bug fixed by #826 . If you apply that PR, then you get a crash in the function exports.token in functions/index.js. The crash can ultimately be traced to the fact that the sample uses the library node-linkedin, which relies for getting user profile data on an API that LinkedIn has stopped providing almost 2 years ago, on May 1 2019:
ArkeologeN/node-linkedin#88

The sample needs to be changed to use an up to date library. I haven't found a replacement library I'm comfortable using yet though.

[liorshk]

Did you find anything?

[jkff]

No, I implemented my own code from scratch. Turned out easier than finding a working library.

[jhuleatt]

@jkff would you be interested in submitting a PR to update the linkedin-auth sample with your from-scratch code?

[jkff]

@jhuleatt Sorry, I don't have time to make a quality PR out of this, and besides, I realized I couldn't use the sample as-is anyway, because my code has a frontend and a backend component, while this sample is frontend-only.

My main learning was that the protocol is just not particularly hard, and you really don't need a library - I spent more time looking for a good library and debugging problems with this sample than it took to implement the protocol myself by reading the LinkedIn OAuth docs https://docs.microsoft.com/en-us/linkedin/shared/authentication/authorization-code-flow?tabs=HTTPS